pyworld vocoder (with SVSCollector bugs) #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support mac anaconda installation
Update scheme for loader
add oniku_kurumi_utagoe_db prepare data
apply black
jimmylitest-1
Can convert npy files to labels txt files and convert label txt files to npy file.
ftshijt
reviewed
Feb 25, 2021
|
Please fix the CI bugs |
|
Please fix the conflict as soon as possible, thanks! |
ftshijt
reviewed
Mar 12, 2021
SVS/bin/train.py
Outdated
| @@ -218,6 +218,14 @@ | |||
| type=int, | |||
| help="how many learning_steps use lr_decay", | |||
| ) | |||
|
|
|||
| parser.add_argument("--vocoder_category", type=str, help="The vocoder to be used (e.g., pyworld).") | |||
There was a problem hiding this comment.
please uniform the interface with current vocoder
| @@ -812,6 +813,10 @@ def __init__( | |||
|
|
|||
| self.use_asr_post = use_asr_post | |||
| self.d_model = d_model | |||
| self.feat_dim_pw = feat_dim_pw | |||
| self.vocoder_category = vocoder_category | |||
| self.output_fc_pw = nn.Linear(d_output, self.feat_dim_pw*2+1) | |||
There was a problem hiding this comment.
this depends on the vocoder category right? add a if here
| align_root_path=args.train_align, | ||
| pitch_beat_root_path=args.train_pitch, | ||
| wav_root_path=args.train_wav, | ||
| pw_f0_root_path=args.train_pw_f0, |
There was a problem hiding this comment.
I think we can uniform this right? Don't need to check vocoder category here, but check it inside the initialization of SVSDataset (init)
…nto SJTMusicTeam-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.