Humble robot status #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wihmajster
commented
Dec 13, 2024
Wihmajster
commented
Dec 13, 2024
Wihmajster
commented
Jan 2, 2025
There was a problem hiding this comment.
There are some suggested improvements, but current implementation works and imo is good enough to be merged at this point. Unaddressed recommendations can be put in a new issue, which could be address at a later time.
@charodziej Can I merge it, or do you want some additional changes?
| self.initialize_robot_status() | ||
|
|
||
| self.joy_subscription_ = self.create_subscription( | ||
| String, 'joy_multiplexer/selected_output', self.joy_multiplexer_callback, 10) |
There was a problem hiding this comment.
I've just checked and the current implementation of joy_multiplexer uses custom message "Topic" (from joystick_control.msg import Topic) instead of String. Though this will be changed when migrating to ros2, so perhaps it's better to leave it as String and in the meantime use Relay node from topic_tools to patch things up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: SKA-Robotics/sirius_robot#3