Refactor ITEM_PROXY usage and update version to 3.2.2#315
Merged
twisti-dev merged 2 commits intoversion/26.1from Apr 19, 2026
Merged
Refactor ITEM_PROXY usage and update version to 3.2.2#315twisti-dev merged 2 commits intoversion/26.1from
twisti-dev merged 2 commits intoversion/26.1from
Conversation
…tem component binding - eliminate unused ITEM_PROXY property and initialization in V26_1Reflection - replace ITEM_PROXY usage with direct call to bindComponents in V26_1SurfPaperNmsItemBridgeImpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the version to 3.2.2 and refactors how item component updates are performed for Minecraft 1.20.6 (v26_1) support. The main change is the removal of the custom reflection proxy for setting item components, switching instead to direct usage of the built-in API. This simplifies the codebase and reduces reliance on reflection.
Key changes include:
Version Update:
gradle.properties.NMS (Net Minecraft Server) Item Component Handling:
V26_1ItemProxyreflection proxy for setting item components with a direct call tonmsItem.builtInRegistryHolder().bindComponents(updatedComponents), using the official API and suppressing deprecation warnings.V26_1Reflection.ITEM_PROXYinV26_1SurfPaperNmsItemBridgeImpl.kt, reflecting the move away from the reflection proxy.Reflection Proxy Cleanup:
V26_1ItemProxyinterface, removing unnecessary reflection-based code for item component updates.ITEM_PROXYproperty and its initialization fromV26_1Reflection, cleaning up unused reflection proxies. [1] [2]