yunhee-week6-hwdone#14
Open
yunheeec wants to merge 1 commit into
Open
Conversation
unknownburphy
left a comment
unknownburphy
left a comment
There was a problem hiding this comment.
전체적으로 아주 잘 구현하신 것 같습니다. 무서운 재능이시군요... LGTM!
| className={`object-cover w-full h-full border-[3px] border-[#FF6841] rounded-xl | ||
| ### FILL ME ### | ||
| className={`object-cover w-full h-full border-[3px] rounded-xl | ||
| ${img.value === 1 ? "border-[#ff4141]" : "border-[#3457e4]"} |
Comment on lines
+70
to
+81
| const handleThumbsUpHover = () => { | ||
| setThumbsUpImage(require("../assets/images/thumbs-up-click.png")); | ||
| }; | ||
| const handleThumbsUpLeave = () => { | ||
| setThumbsUpImage(require("../assets/images/thumbs-up-icon.png")); | ||
| }; | ||
| const handleThumbsDownHover = () => { | ||
| setThumbsDownImage(require("../assets/images/thumbs-down-click.png")); | ||
| }; | ||
| const handleThumbsDownLeave = () => { | ||
| setThumbsDownImage(require("../assets/images/thumbs-down-icon.png")); | ||
| }; |
unknownburphy
approved these changes
May 3, 2024
minseo25
reviewed
May 4, 2024
| // ### thumbsUpImage Event ### | ||
| onMouseOver={handleThumbsUpHover} | ||
| onMouseOut={handleThumbsUpLeave} | ||
| onClick={() => vote(1)} |
There was a problem hiding this comment.
저는 투표 시 vote(1); 후에 getImage(); 호출을 통해 다음 투표할 이미지를 불러왔는데
개인 구현 차이 같아서 참고만 하셔도 좋을 것 같아요~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💎 과제 구현 설명
🏁 PR 체크리스트
🖼️ Screenshot / Video
🙌 Issue