fix: fargate SecurityGroupPolicy ids values #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashimal
approved these changes
Dec 2, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds explicit tostring() conversions to module.eks.node_security_group_id values used in Fargate SecurityGroupPolicy Kubernetes manifests. The change addresses potential type compatibility issues when specifying security group IDs in the groupIds field of SecurityGroupPolicy resources.
Key Changes
- Added
tostring()wrapper aroundmodule.eks.node_security_group_idin SecurityGroupPolicy manifests - Applied consistently across both standard Fargate profiles and Karpenter-specific Fargate configurations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| karpenter.tf | Added tostring() conversion for security group ID in Karpenter namespace SecurityGroupPolicy |
| fargate_profile.tf | Added tostring() conversion for security group ID in Fargate namespace SecurityGroupPolicy |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.