Skip to content
This repository was archived by the owner on Jan 11, 2026. It is now read-only.

[REFACTOR] 게시글/댓글 카운트 테이블 분리 및 로직 리팩토링#31

Merged
msk226 merged 12 commits intodevelopfrom
SPOT-304/refactor
Aug 12, 2025
Merged

[REFACTOR] 게시글/댓글 카운트 테이블 분리 및 로직 리팩토링#31
msk226 merged 12 commits intodevelopfrom
SPOT-304/refactor

Conversation

@msk226
Copy link
Member

@msk226 msk226 commented Aug 12, 2025

#️⃣ 연관된 이슈


🔎 작업 내용

  • 게시글/댓글 카운트 테이블(PostStats) 분리
    • likeCount, commentCount, hitCount, scrapNum 필드를 별도 테이블로 이동
    • 기존 Post / Comment 엔티티에서 카운트 필드 제거
  • 카운트 증가/감소 로직 리팩토링
    • 좋아요/스크랩/조회수/댓글 수 변경 시 PostStats를 통해 관리
    • 동시성 문제 최소화를 위해 DB 단일 업데이트 쿼리 적용
  • 불필요한 양방향 매핑 제거
  • 서비스 로직 정리
    • 카운트 처리 로직 추출 및 메서드화
    • existsById / getReferenceById로 조회 최적화

📷 스크린샷 (선택)

작업한 결과물에 대한 간단한 스크린샷을 올려주세요.


💬리뷰 요구사항 (선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요.

Summary by CodeRabbit

  • New Features

    • Post detail now includes imageUrl.
    • More consistent like/scrap counters and responses.
  • Refactor

    • Renamed query endpoints (e.g., singlePost→getSingle, getPagingPost→getPaging, getScrapPagingPost→getScraps).
    • Pagination now uses Pageable across list endpoints.
    • Added access-token security to single post and scraps endpoints.
    • Simplified comment responses (removed parentCommentId, like/dislike fields); view counts now return 0 in lists/details.
  • Documentation

    • Consolidated/updated OpenAPI tags and descriptions; removed many field-level annotations.
  • Tests

    • Updated tests to align with new APIs and counting logic.

@msk226 msk226 self-assigned this Aug 12, 2025
@msk226 msk226 added the ♻️ refactor Code Refactoring label Aug 12, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 12, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors post counters into a new PostStats entity/repository, migrates like/scrap/comment increments to PostStats, converts Post/PostComment to JPA entities, removes comment-like infrastructure, updates repositories/queries, adjusts controllers (pagination, security, docs), updates DTOs/tests, and tweaks scheduler import packages.

Changes

Cohort / File(s) Summary
Scheduler package/import alignment
src/main/java/com/example/spot/common/scheduler/PostSortCommentsScheduler.java, src/main/java/com/example/spot/common/scheduler/PostSortLikesScheduler.java, src/main/java/com/example/spot/common/scheduler/PostSortRealTimeScheduler.java, src/main/java/com/example/spot/post/infrastructure/jpa/schedule/PostScheduleCommentsRepository.java, .../PostScheduleLikesRepository.java, .../PostScheduleRealTimeRepository.java
Move schedule repositories to .infrastructure.jpa.schedule; adjust imports; no behavior changes.
PostStats introduction & use-case refactors
src/main/java/com/example/spot/post/domain/PostStats.java, src/main/java/com/example/spot/post/infrastructure/jpa/PostStatsRepository.java, src/main/java/com/example/spot/post/application/command/impl/LikePostUseCaseImpl.java, src/main/java/com/example/spot/post/application/command/impl/ManagePostCommentUseCaseImpl.java, src/main/java/com/example/spot/post/application/command/impl/ManagePostUseCaseImpl.java, src/main/java/com/example/spot/post/application/command/impl/ScrapPostUseCaseImpl.java
Add PostStats entity + repository; move like/scrap/comment/hit counters to PostStats; use existence checks and JPA references; update use-cases to call PostStatsRepository for increments/decrements and adapt helper flows and constructor deps.
Domain model updates
src/main/java/com/example/spot/post/domain/Post.java, src/main/java/com/example/spot/post/domain/PostComment.java, src/main/java/com/example/spot/post/domain/schedule/PostScheduleRealTime.java
Make Post and PostComment JPA entities (id, mappings, Lombok), remove embedded counter fields and nested comment/like collections, add Post.edit, set real-time hitSize to 0.
Repository changes
src/main/java/com/example/spot/post/infrastructure/jpa/PostRepository.java, src/main/java/com/example/spot/post/infrastructure/jpa/LikedPostRepository.java, src/main/java/com/example/spot/post/infrastructure/jpa/MemberScrapRepository.java
Add PostRepository.getById and new JPQL queries to exclude reported posts; add LikedPostRepository.deleteByMemberIdAndPostId(int) returning affected rows; add MemberScrapRepository.deleteByPostIdAndMemberId(int).
Querydsl ordering tweaks
src/main/java/com/example/spot/post/infrastructure/querydsl/impl/PostRepositoryImpl.java, src/main/java/com/example/spot/post/infrastructure/querydsl/impl/PostCommentRepositoryImpl.java
Adjust ordering for real-time ranking (use liked/postComment sizes) and simplify comment ordering to createdAt only.
Scrap API signature and callers
src/main/java/com/example/spot/post/application/command/ScrapPostUseCase.java, src/main/java/com/example/spot/post/application/command/impl/ScrapPostUseCaseImpl.java, src/main/java/com/example/spot/post/presentation/controller/command/ScrapPostController.java
Change cancelPostScraps to accept memberId parameter; controller updated to pass current user id; implementations adapted.
Removal of comment-like querying
src/main/java/com/example/spot/post/application/query/GetLikedPostCommentUseCase.java, src/main/java/com/example/spot/post/application/query/impl/GetLikedPostCommentUseCaseImpl.java, src/main/java/com/example/spot/post/infrastructure/jpa/LikedPostCommentRepository.java
Delete interface, implementation, and repository related to post-comment like/dislike queries.
GetPost use-case & controller refactor
src/main/java/com/example/spot/post/application/query/impl/GetPostUseCaseImpl.java, src/main/java/com/example/spot/post/presentation/controller/query/GetPostController.java, src/main/java/com/example/spot/post/presentation/controller/command/ManagePostController.java, src/main/java/com/example/spot/post/presentation/controller/command/LikePostController.java, src/main/java/com/example/spot/post/presentation/controller/command/ManagePostCommentController.java
Switch to Pageable, rename endpoints, add class-level OpenAPI/security metadata, remove per-comment like/dislike uses, stop incrementing view hit in standard flow (viewCount zeros), and update docs/parameter annotations.
DTO cleanup & mappings
Multiple DTOs (.../dto/request/..., .../dto/response/comment/..., .../dto/response/post/...)
Remove Swagger @Schema annotations, drop comment-like/parent fields from comment DTOs, add imageUrl to PostSingleResponse, set various counts (view/comment) to 0 in mappers, tidy imports and ordering.
Removed DTOs
src/main/java/com/example/spot/post/presentation/dto/response/post/PostHomeResponse.java, src/main/java/com/example/spot/post/presentation/dto/request/post/PostLikeRequest.java
Delete unused DTO classes.
Tests updated
src/test/java/com/example/spot/service/post/GetPostUseCaseTest.java, src/test/java/com/example/spot/service/post/PostCommandServiceTest.java
Adjust tests to use PostStatsRepository and updated repositories/APIs; remove assertions dependent on removed counters and nested comment features; update entity builders and mocks.

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant API as LikePostController
  participant UC as LikePostUseCaseImpl
  participant PR as PostRepository
  participant MR as MemberRepository
  participant LR as LikedPostRepository
  participant PS as PostStatsRepository

  User->>API: POST /posts/{id}/like
  API->>UC: likePost(postId, memberId)
  UC->>PR: existsById(postId)
  UC->>MR: existsById(memberId)
  UC->>PR: getReferenceById(postId)
  UC->>MR: getReferenceById(memberId)
  UC->>LR: save(new LikedPost)
  UC->>PS: incrementLike(postId)
  UC->>PS: getLikeCount(postId)
  UC-->>API: PostLikeResponse(postId, likeCount)
  API-->>User: 200 OK
Loading
sequenceDiagram
  actor User
  participant API as ScrapPostController
  participant UC as ScrapPostUseCaseImpl
  participant PR as PostRepository
  participant MR as MemberRepository
  participant SR as MemberScrapRepository
  participant PS as PostStatsRepository

  User->>API: POST /posts/{id}/scrap
  API->>UC: scrapPost(postId, memberId)
  UC->>PR: existsById(postId)
  UC->>MR: existsById(memberId)
  UC->>PR: getReferenceById(postId)
  UC->>MR: getReferenceById(memberId)
  UC->>SR: save(new MemberScrap)
  UC->>PS: incrementScrap(postId)
  UC->>PS: getScrapNum(postId)
  UC-->>API: ScrapPostResponse
  API-->>User: 200 OK
Loading
sequenceDiagram
  actor User
  participant API as ManagePostController
  participant UC as ManagePostUseCaseImpl
  participant MR as MemberRepository
  participant PR as PostRepository
  participant PSR as PostStatsRepository

  User->>API: POST /spot/posts (multipart)
  API->>UC: createPost(memberId, PostCreateRequest)
  UC->>MR: getReferenceById(memberId)
  UC->>UC: uploadImageIfPresent()
  UC->>PR: save(Post)
  UC->>PSR: save(PostStats with 0 counters)
  UC-->>API: PostCreateResponse
  API-->>User: 201 Created
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related issues

Possibly related PRs

Poem

In fields of code I hop with glee,
New stats burrowed under the post-tree.
Likes and scraps in one snug den,
Controllers trimmed, we sprint again.
Comments simplified, the grass grows neat—
Ship it quick, with thumping feet! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd8617f and 1b57152.

📒 Files selected for processing (53)
  • src/main/java/com/example/spot/common/scheduler/PostSortCommentsScheduler.java (1 hunks)
  • src/main/java/com/example/spot/common/scheduler/PostSortLikesScheduler.java (1 hunks)
  • src/main/java/com/example/spot/common/scheduler/PostSortRealTimeScheduler.java (1 hunks)
  • src/main/java/com/example/spot/post/application/command/ScrapPostUseCase.java (1 hunks)
  • src/main/java/com/example/spot/post/application/command/impl/LikePostUseCaseImpl.java (4 hunks)
  • src/main/java/com/example/spot/post/application/command/impl/ManagePostCommentUseCaseImpl.java (3 hunks)
  • src/main/java/com/example/spot/post/application/command/impl/ManagePostUseCaseImpl.java (2 hunks)
  • src/main/java/com/example/spot/post/application/command/impl/ScrapPostUseCaseImpl.java (5 hunks)
  • src/main/java/com/example/spot/post/application/query/GetLikedPostCommentUseCase.java (0 hunks)
  • src/main/java/com/example/spot/post/application/query/impl/GetLikedPostCommentUseCaseImpl.java (0 hunks)
  • src/main/java/com/example/spot/post/application/query/impl/GetPostUseCaseImpl.java (5 hunks)
  • src/main/java/com/example/spot/post/domain/Post.java (1 hunks)
  • src/main/java/com/example/spot/post/domain/PostComment.java (1 hunks)
  • src/main/java/com/example/spot/post/domain/PostStats.java (1 hunks)
  • src/main/java/com/example/spot/post/domain/schedule/PostScheduleRealTime.java (2 hunks)
  • src/main/java/com/example/spot/post/infrastructure/jpa/LikedPostCommentRepository.java (0 hunks)
  • src/main/java/com/example/spot/post/infrastructure/jpa/LikedPostRepository.java (2 hunks)
  • src/main/java/com/example/spot/post/infrastructure/jpa/MemberScrapRepository.java (2 hunks)
  • src/main/java/com/example/spot/post/infrastructure/jpa/PostRepository.java (1 hunks)
  • src/main/java/com/example/spot/post/infrastructure/jpa/PostStatsRepository.java (1 hunks)
  • src/main/java/com/example/spot/post/infrastructure/jpa/schedule/PostScheduleCommentsRepository.java (1 hunks)
  • src/main/java/com/example/spot/post/infrastructure/jpa/schedule/PostScheduleLikesRepository.java (1 hunks)
  • src/main/java/com/example/spot/post/infrastructure/jpa/schedule/PostScheduleRealTimeRepository.java (1 hunks)
  • src/main/java/com/example/spot/post/infrastructure/querydsl/impl/PostCommentRepositoryImpl.java (0 hunks)
  • src/main/java/com/example/spot/post/infrastructure/querydsl/impl/PostRepositoryImpl.java (1 hunks)
  • src/main/java/com/example/spot/post/presentation/controller/command/LikePostController.java (0 hunks)
  • src/main/java/com/example/spot/post/presentation/controller/command/ManagePostCommentController.java (2 hunks)
  • src/main/java/com/example/spot/post/presentation/controller/command/ManagePostController.java (1 hunks)
  • src/main/java/com/example/spot/post/presentation/controller/command/ScrapPostController.java (1 hunks)
  • src/main/java/com/example/spot/post/presentation/controller/query/GetPostController.java (3 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/request/comment/CommentCreateRequest.java (1 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/request/post/PostCreateRequest.java (1 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/request/post/PostLikeRequest.java (0 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/request/post/PostUpdateRequest.java (1 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/request/post/ScrapAllDeleteRequest.java (1 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/response/comment/CommentCreateResponse.java (1 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/response/comment/CommentDetailResponse.java (2 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/response/post/PostAnnouncementResponse.java (1 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/response/post/PostBest5DetailResponse.java (1 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/response/post/PostBest5Response.java (1 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/response/post/PostBoard5Response.java (0 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/response/post/PostCreateResponse.java (1 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/response/post/PostHomeResponse.java (0 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/response/post/PostLikeResponse.java (0 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/response/post/PostPagingDetailResponse.java (2 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/response/post/PostPagingResponse.java (1 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/response/post/PostRepresentativeDetailResponse.java (1 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/response/post/PostRepresentativeResponse.java (1 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/response/post/PostSingleResponse.java (2 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/response/post/ScrapPostResponse.java (1 hunks)
  • src/main/java/com/example/spot/post/presentation/dto/response/post/ScrapsPostDeleteResponse.java (1 hunks)
  • src/test/java/com/example/spot/service/post/GetPostUseCaseTest.java (5 hunks)
  • src/test/java/com/example/spot/service/post/PostCommandServiceTest.java (15 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch SPOT-304/refactor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@msk226 msk226 merged commit 51c5110 into develop Aug 12, 2025
1 of 2 checks passed
@msk226 msk226 deleted the SPOT-304/refactor branch September 3, 2025 10:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

♻️ refactor Code Refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant