Adding support for virtual passkey functionality #214
Conversation
Summary of ChangesHello @spoore1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the sssd_test_framework's capabilities by introducing robust support for testing virtual passkey functionality. It establishes a dedicated utility for programmatic control over virtual FIDO devices, seamlessly integrates this control into existing client and IPA roles, and provides advanced authentication methods to simulate diverse virtual passkey login scenarios. This foundational work enables automated and thorough validation of SSSD's interaction with passkey-based authentication mechanisms. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for testing virtual passkey (vfido) functionality. It introduces a new Vfido utility class, and adds methods to IPAUser and SUAuthenticationUtils to handle passkey registration and authentication in tests. The changes are a good step forward, but I've found a few issues. There's a critical bug in vfido.py where pin_disable calls the wrong command, and another critical bug in authentication.py with incorrect match/case syntax that will prevent PIN validation from working. I've also left several medium-severity comments regarding hardcoded paths, magic strings, and inconsistencies in docstrings and messages. Please address these points to improve the robustness and maintainability of the new test utilities.
spoore1
force-pushed
the
gdm_passkey
branch
3 times, most recently
from
8c82ea5 to
5f65046
Compare
It does require the vhci-hcd kernel module. That will be taken care of in the sssd-ci-containers setup code here: I've updated the systemd unit file to modprobe that before starting the service. If it's not in the PR yet, it will be soon since I've updated my local repo already. |
There was a problem hiding this comment.
It does require the vhci-hcd kernel module. That will be taken care of in the sssd-ci-containers setup code here: SSSD/sssd-ci-containers#151
I've checked it and this module is available in both fedora and ubuntu, so we shouldn't have any problems there.
I've updated the systemd unit file to modprobe that before starting the service. If it's not in the PR yet, it will be soon since I've updated my local repo already.
It is and it looks good.
|
|
||
| result = self.host.conn.exec(["/opt/test_venv/bin/scauto", "gui", "done"]) | ||
| self.host.conn.exec(["systemctl", "stop", "gdm"], raise_on_error=False) | ||
| self.init_completed = False |
2 participants
No description provided.