sysdb: Execute override code even if no templates exist

[justin-stephenson]

Fixes an issue where ID overrides were not applied properly for the Default Trust View.

[gemini-code-assist]

Code Review

This pull request addresses a bug where ID overrides were not being applied if no templates were present. The change correctly removes the else block that caused a premature exit from sysdb_apply_default_override, ensuring that override logic is always executed. Additionally, a misleading comment has been removed, improving code clarity. The fix appears correct and complete, and I have no further suggestions.

[alexey-tikhonov]

@justin-stephenson, is this related to #8059?

[justin-stephenson]

@justin-stephenson, is this related to #8059?

Yes.

[justin-stephenson]

Added @pytest.mark.parametrize("view", ["Default Trust View", "example1"]) in ID override template tests in #7517 to cover this.

[alexey-tikhonov]

@justin-stephenson, is this related to #8059?

Yes.

Could you please add corresponding "Resolves:" line to the commit message?

[justin-stephenson]

Could you please add corresponding "Resolves:" line to the commit message?

Added, thanks.

[thalman]

LGTM, thanks

[pbrezina]

@justin-stephenson only backport to 2-9? Not 2-10 2-11?

[justin-stephenson]

@justin-stephenson only backport to 2-9? Not 2-10 2-11?

https://github.com/SSSD/sssd/pull/7924 was 2-9 backport only was 2-9 only also, I set the same here.

[alexey-tikhonov]

@justin-stephenson, could you please rebase?

[justin-stephenson]

@justin-stephenson, could you please rebase?

Done.

[alexey-tikhonov]

Pushed PR: #8070

• master
  • 9cbb08d - sysdb: Execute override code even if no templates exist
• sssd-2-9
  • 6d595cd - sysdb: Execute override code even if no templates exist