-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor nexus writer #306
Refactor nexus writer #306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
A couple of other things that might as well be done now:
- Could the term "run file" be revisited. This does not really seem to describe the thing it actually refers to (a separate file describing a run vs. a collection of run metadata).
- Could
crate::hdf5_file::run_file_components
be moved tocrate::hdf5_file::run_file::components
?
The This PR is the first in a couple I've got planned which will, among other things make the naming conventions more logical. It's probably okay to leave |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Summary of changes
thiserror
style error handling removing over-reliance onanyhow
. The code now conforms to ADR 7. Standardise error handling.hdf5::{Group, Dataset, Attribute}
inhdf5_writer.rs
.Location
field in non-hdf5 related errors.time
Dataset with a "units" and "start" attribute, where "start" denotes the RFC3999 date/time to which the time value is relative to.Instruction for review/testing