-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set open telemetry levels via an environment variable #318
Merged
DanNixon
merged 17 commits into
STFC-ICD-Research-and-Design:main
from
Modularius:Set-OpenTelemetry-levels-via-an-environment-variable
Feb 13, 2025
Merged
Set open telemetry levels via an environment variable #318
DanNixon
merged 17 commits into
STFC-ICD-Research-and-Design:main
from
Modularius:Set-OpenTelemetry-levels-via-an-environment-variable
Feb 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes the way we set OpenTelemetry levels and tidies up some spans.
otel_level
cli option from all components.otel
target andtarget = "otel"
syntax in spans/events (This accounts for most files changed). This target is not really useful, though OpenTelemetry-only targets may be introduced in the future.trace-to-events
, functions processing individual channels moved to their own filechannels.rs
. This allows the observability level for these to be set via includingtrace_to_events::channels=????
inOTEL_LOG
. At present useinfo
to include channels, andwarn/error/off
to exclude.spanned_root_as
functions changed totrace
frominfo
.digitiser_id
tag toDigitiser Event List
span in digitiser aggregator.Instruction for review/testing