Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set open telemetry levels via an environment variable #318

Conversation

Modularius
Copy link
Contributor

Summary of changes

Changes the way we set OpenTelemetry levels and tidies up some spans.

  • Removed otel_level cli option from all components.
  • Modified OpenTelemetry filter layer to use environment variable "OTEL_LOG" to determine which level to filter crates/modules on.
  • Removed references to the otel target and target = "otel" syntax in spans/events (This accounts for most files changed). This target is not really useful, though OpenTelemetry-only targets may be introduced in the future.
  • In trace-to-events, functions processing individual channels moved to their own file channels.rs. This allows the observability level for these to be set via including trace_to_events::channels=???? in OTEL_LOG. At present use info to include channels, and warn/error/off to exclude.
  • Level of spanned_root_as functions changed to trace from info.
  • Added digitiser_id tag to Digitiser Event List span in digitiser aggregator.

Instruction for review/testing

  • General code review
  • Has been tested on simulated data

@Modularius Modularius requested a review from DanNixon February 5, 2025 13:47
@Modularius Modularius requested a review from DanNixon February 13, 2025 10:03
@DanNixon DanNixon merged commit c0cd5e8 into STFC-ICD-Research-and-Design:main Feb 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants