Gpu linear blend skinning by ntsh-oni · Pull Request #1077 · STORM-IRIT/Radium-Engine

ntsh-oni · 2024-03-04T13:49:04Z

Pull Request Description

This pull request is about Linear Blend Skinning on GPU. It is currently done on CPU at the moment, as the vertices are modified on CPU, but doing it on GPU could introduce a speedup.

The feature is not ready yet, issues with Skeletal Components and passing data to different vertex shaders.

What kind of change does this PR introduce?
- feature
What is the current behavior?

Linear blend skinning is performed on CPU.

What is the new behavior (if this is a feature change)?

Linear blend skinning would be performed on GPU.

Expose binding

Co-authored-by: Nicolas Mellado <nmellado0@gmail.com>

Fix STORM-IRIT#1023

Core variables

isnormal return false for 0., not sure 0. has to be considered invalid (e.g. for skinning weight).

[engine] mesh override getNumVertices for GeometryDisplayable. remove uneeded export api on template

remove forward old draw wireframe

[engine] Mesh remove debug print. remove mesh debug message print mesh name on invalid layer

tmp disable rotation center skinning

…fix a maximum joints count in LBS shader

dlyr and others added 30 commits November 16, 2022 08:18

[examples] Use keymapping without modifiers.

ce0eddd

[doc] Improve KeyMappingManager doc with cleaner snippets.

13ea5f4

[gui] clean viewer commented lines.

4c5acd6

Merge pull request STORM-IRIT#906 from dlyr/exposeBinding

03330bf

Expose binding

Update version to 1.3.12 [skip ci]

dd64288

[core] Fix taskQueue worker starts while runInThisThread.

df19a63

[core] Allow no thread task queue, and use 2nd form of wait.

b40cbec

[engine] gpuTaskQueue has no threads.

40ec570

[examples] Add a second thread in TexturedQuadDynamic.

6a01296

[core] TaskQueue lock guard task list modifications.

6715c39

[core] typo in comment TaskQueue.hpp

5564ae3

Co-authored-by: Nicolas Mellado <nmellado0@gmail.com>

[core] move lock before assert in addDependency TaskQueue.cpp

c10e543

[core] Rephrase doc in TaskQueue.hpp

1b91655

[core] clean include and move lock in TaskQueue.cpp

d55d2f6

[examples] Stops second when quit TexturedQuadDynamic.

6944e47

Merge pull request STORM-IRIT#1024 from dlyr/fix-task-queue

a3d0593

Fix STORM-IRIT#1023

Update version to 1.3.13 [skip ci]

fc8fc24

[core] Add generic variable set

f447977

[core] fix codacy bad reporting

550a3f8

[unittests][core] test generic variable set

166ccfc

Merge pull request STORM-IRIT#1022 from MathiasPaulin/core-variables

ffc1bf4

Core variables

Update version to 1.3.14 [skip ci]

fa88b85

[engine] guard empty m_animations access.

8408906

[engine] Add get/set bone transformation using boneIdx.

cc5af82

[engine] add mesh name, bone weight, bone bind matrix setters.

09e9b71

[core] use isinfinite instead of isnormal to check invalid numbers.

76f0b1d

isnormal return false for 0., not sure 0. has to be considered invalid (e.g. for skinning weight).

[core] Add makeSharpCylinder, with side segment specification.

79f01fa

[core] Add smoothstep template (as in glsl).

d953f0f

[examples] simple skinning example.

314e16f

[engine] Add doc to new methods in SkinningComponent.

b5d1833

dlyr and others added 29 commits April 6, 2023 18:59

[engine] Add empty ctor.

d36fbc0

[engine] use geometrydisplayable for components.

92fd804

[engine] rename correspondance -> matching

7d25da6

[engine] mesh override getNumVertices for GeometryDisplayable. remove uneeded export api on template

[engine] GeometrySystem use GeometryDisplayable comp.

d6015ad

[examples] Start using GeometryDisplayable in draw prim.

3741bf2

[engine] GeometryComponent clean include.

d06fed2

[engine] Renderer remove debug print.

fd3ea55

remove forward old draw wireframe

[engine] handle line index layer picking render mode.

ed01e2d

[engine] Mesh remove debug print. remove mesh debug message print mesh name on invalid layer

[core] MeshPrimitives remove debug print.

9b488b9

[core] IndexedGeometry remove debug print.

3560eca

[examples] HelloRadium remove debug print.

a3ad0a5

[engine] Remove unused LineMeshComponent.

78c3db9

[examples] add fixed light in skinning example.

074d331

[core] use inverse transpose for normal lbs.

a14f4da

[core] comment typo in trianglemesh

269e2b2

[core][engine] use AttribArrayGeometry as skinning data.

420be76

tmp disable rotation center skinning

[core] register rw on AttribArrayGeometry for SurfaceMeshComponent.

5ac4410

Merge branch 'curve-editor-example-app' into release-candidate

7a54114

[external] Fix pass Qt version to external build.

271bdbd

Merge branch 'fix-external-qt-version' into paintyVersionRpRb

485590f

[core] Export VariableSetFunctions.

a02b6b5

fix msvc warning

de5cfb2

add missing exports

7bc86f7

remove copy of unexisting assets

172f7ff

msvc error on capture ? to revert

e62fe7e

start linear blend skinning on gpu

0a235a9

add lbs to blinn phong vertex shader

e95c5c5

build render technique

4fec4f3

do not update vertices on CPU if the skinning types uses the GPU and …

a5f4052

…fix a maximum joints count in LBS shader

dlyr marked this pull request as draft July 3, 2024 08:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gpu linear blend skinning#1077

Gpu linear blend skinning#1077
ntsh-oni wants to merge 3066 commits intoSTORM-IRIT:release-candidatefrom
ntsh-oni:gpu-linear-blend-skinning

ntsh-oni commented Mar 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

ntsh-oni commented Mar 4, 2024

Pull Request Description

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants