Skip to content

Build the cache without active #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Build the cache without active #1313

wants to merge 5 commits into from

Conversation

jesusbv
Copy link
Collaborator

@jesusbv jesusbv commented Mar 28, 2025

Description

When building the cache '-active' should not be part of it, otherwise, we would never find '-inactive' entries in the cache

  • Related Issue / Ticket / Trello card:

How to test

Behaviour should remain the same

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.

When building the cache '-active' should not be part of it,
otherwise, we would never find '-inactive' entries in the cache
@jesusbv jesusbv added the 2.22 label Mar 28, 2025
@jesusbv jesusbv requested review from digitaltom and rjschwei March 28, 2025 11:49
@jesusbv jesusbv self-assigned this Mar 28, 2025
@jesusbv
Copy link
Collaborator Author

jesusbv commented Mar 28, 2025

I will add a set_cache_active method as well

@jesusbv jesusbv removed the 2.22 label Mar 31, 2025
@jesusbv
Copy link
Collaborator Author

jesusbv commented Apr 8, 2025

closing in favour of #1314, based on @rjschwei request to join the two changes in the same PR

@jesusbv jesusbv closed this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants