fix(models): bound provider-facing observation output - #878
Open
snvtac wants to merge 1 commit into
Open
Conversation
Member
|
But we can already truncate observations with the jinja templates, why is this needed? |
Member
|
see the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extra.raw_outputfor local trajectory/debug use.mini.yamlobservation template, and provider message preparation strippingextra.raw_output.Fixes #873
Validation
uv run pytest tests/models/test_observation_truncation.pyuv run pytest tests/models -n auto-> 140 passed, 1 warninguv run pytest -n auto-> 536 passed, 76 skipped, 1 warninguv run ruff check src testsuv run ruff format --check src testsuv run pylint src/minisweagent --errors-onlygit diff --checkNotes
Validation used a repo-local
.venvand.uv-cache; both were removed after verification along with ignored test/lint caches.