fix(config): remove default.yaml, which paired text prompts with the tool-call model - #904
Open
EnesYilmazcode wants to merge 1 commit into
Open
Conversation
…tool-call model default.yaml told the model to answer in mswea_bash_command text blocks and repeated that guidance in its format_error_template, but the default model class only parses native tool calls, so a model that followed the prompts could only loop through format errors into RepeatedFormatError. hello_world.py (the only runtime consumer) now loads mini.yaml; tests that used default.yaml as their text-format agent config now load mini_textbased.yaml.
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default.yamltold the model to answer inmswea_bash_commandtext blocks and repeated that guidance in itsformat_error_template, buthello_world.pypaired it with the default model class, which only parses native tool calls. A model that followed the prompts could only loop through format errors intoRepeatedFormatError.Rather than fixing the template, this deletes the config, as suggested in #899 ("might actually just get rid of
default.yaml? I guess it's only used inhello_world.pyright now") and on #900 ("it's also not really used by anything but demos, so might actually just remove the whole config").Changes:
hello_world.py(the only runtime consumer) now loadsmini.yamldefault.yamlas their text-format agent config (tests/agents/test_default.py,tests/agents/test_interactive.py,tests/run/test_cli_integration.py,tests/run/test_save.py) now loadmini_textbased.yaml, which has the same text templatesdefault.yamlline from the config READMENo references to
default.yamlremain after this.Test
The four updated test files give identical results on this branch and on
main.DefaultAgentinstantiates cleanly withmini.yaml's agent config, sohello_world.pystill works.Fixes #899