feat: add custom shell support for Windows PowerShell compatibility - #908
Open
RainCongeals wants to merge 4 commits into
Open
feat: add custom shell support for Windows PowerShell compatibility#908RainCongeals wants to merge 4 commits into
RainCongeals wants to merge 4 commits into
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for using a custom shell executable in the LocalEnvironment.
Motivation:
The default subprocess shell execution on Windows can sometimes behave unexpectedly with complex commands or specific environment configurations. By allowing users to specify a custom shell (e.g., pwsh.exe for PowerShell Core), we improve compatibility and reliability for Windows users.
Changes:
Added shell_executable parameter to LocalEnvironment.init.
Updated execute_command to use the specified shell when provided.
Maintained backward compatibility (defaults to standard behavior if not specified).