fix(models): stop retrying permanent context overflow errors - #923
Open
daleselaji-dev wants to merge 1 commit into
Open
fix(models): stop retrying permanent context overflow errors#923daleselaji-dev wants to merge 1 commit into
daleselaji-dev wants to merge 1 commit into
Conversation
daleselaji-dev
marked this pull request as ready for review
August 4, 2026 03:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #921.
Context-window overflow responses are permanent request errors, but the model retry loop currently treats them like transient provider failures. A single oversized prompt can therefore resend the full history up to ten times before surfacing the original error.
This change:
context_length_exceededandcontext_window_exceeded400 responses as non-retryable;Root cause
Provider-specific model classes only excluded authentication errors and
KeyboardInterruptfrom Tenacity retries. Context overflow was raised as the generic API exception, so the retry policy resent an unchanged request even though retrying cannot reduce its size.Validation
python -m pytest -q tests/models/test_context_length_retry.py tests/models/test_openrouter_textbased_model.py— 11 passedpython -m compileall -q src/minisweagent/models tests/models/test_context_length_retry.py— passedThe broader model test collection still has six unrelated failures in tests that import the optional
litellmdependency; no changed code is involved in those failures.Compatibility
Only recognized context-overflow 400 responses change behavior. Authentication, rate-limit, network, and other provider errors keep their existing retry policies.