[issue #98] Unify Saihai naming and align setup/classify docs with implementation - #122
[issue #98] Unify Saihai naming and align setup/classify docs with implementation#122Saber5656 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b265bfa18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| To recover from an invalid explicit selector, unset | ||
| `SAIHAI_DIRECTORY_PATH_ENV` (and legacy `SAHAI_DIRECTORY_PATH_ENV`) so normal | ||
| primary-checkout discovery can resume. | ||
| `SAIHAI_DIRECTORY_PATH_ENV` so normal primary-checkout discovery can resume. | ||
| Compatibility selector names are listed only in the table above. |
There was a problem hiding this comment.
Include the legacy selector in recovery steps
When a migrated environment still has SAHAI_DIRECTORY_PATH_ENV set to a bad path, unsetting only SAIHAI_DIRECTORY_PATH_ENV will not recover discovery: directory_paths.resolve_env_file() still treats LEGACY_CATALOG_ENV_KEY as an explicit selector and load_environment() fails before falling back to the checkout catalog. Since this page now documents SAHAI_DIRECTORY_PATH_ENV as a supported compatibility selector, the recovery instruction should tell operators to unset both selector variables.
Useful? React with 👍 / 👎.
Summary
Milestone M0 (contract hygiene) of the deterministic-harness migration (epic #120). Fixes the self-contradicting product naming and setup/classify documentation so the docs match the implemented contracts, restoring the fail-closed "documentation is the contract" posture.
Changes
README.md/README.ja.mdSahai/SAHAI_*names remain only in the compatibility-alias table rows (added the missingSAHAI_DIRECTORY_PATH_ENV→SAIHAI_DIRECTORY_PATH_ENValias row).SAIHAI_ROOTdefaults to the primary checkout, and the normal entrypoint validates all nine canonical paths fail-closed.classifydocumentation corrected to the real two-axis contract:--mode {fast,strict}plus the separate--organization-state {enabled,disabled,maintenance}; README examples updated to runnable invocations.docs/configuration.mdscripts/setup_directory_paths.py's actual argument contract and fail-closed behavior (existing-catalog overwrite refusal, bootstrap-only consumers note).Testing
grep -rn "Sahai[^i]" README.md README.ja.md docs/→ zero hits; case-insensitive sweep shows 10 remaining legacy-alias occurrences, all inside compatibility table rows.scripts/setup_directory_paths.pyin a throwaway directory: creation and--checksucceed, catalog file mode0600, omitting a required option fails closed with exit 2.scripts/configure_organization.pyparser verified (--help) and the documented examples executed successfully against an isolated catalog.python3 scripts/validate_all.py→result: pass(41 suites).Review
tech-docsrole review (independent session): approve, zero findings. Verified naming sweep, setup/classify contract fidelity against the parsers, EN/JA synchronization, and scope containment.Closes #98
🤖 Generated with Claude Code