-
Notifications
You must be signed in to change notification settings - Fork 0
feat: webview for the graphical editor #1317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…itor-vscode-client
…itor-editor-package
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1317 +/- ##
==========================================
- Coverage 99.73% 98.48% -1.25%
==========================================
Files 120 136 +16
Lines 13031 13886 +855
Branches 4266 4439 +173
==========================================
+ Hits 12996 13676 +680
- Misses 35 208 +173
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Edit: Has been resolved. @lars-reimann There seems to be an issue with the current implementation of the graphical-editor service in the language server. During the initialization of the class, I store references to various services (e.g. the IndexManager). This pattern was taken from other ServiceProviders.
I assume, that I made a mistake during the registration of the service (in @safe-ds/lang/safe-ds-module.ts). |
@lars-reimann
|
Edit: All these issues have been resolved. Bug 3 |
…itor-vscode-client
…into custom-editor-vscode-client
…itor-editor-package
…itor-vscode-client
…into custom-editor-vscode-client
… into custom-editor-editor-package
Related to #1243
Summary of Changes
Adds the svelte package, that provides the webview for the graphical editor.