Skip to content

build(storybook): configure storybook to use vite instead of webpack #7319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

build(storybook): configure storybook to use vite instead of webpack #7319

wants to merge 2 commits into from

Conversation

nineteen88
Copy link
Contributor

Proposed behaviour

  • update welcome pages to be .jsx
  • configure main.ts for the vite config
  • add a vite.config file

Current behaviour

  • Storybook is currently using webpack

Checklist

  • Commits follow our style guide
  • Storybook added or updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@nineteen88 nineteen88 force-pushed the storybook-to-vite branch from 51fa237 to 914c203 Compare May 1, 2025 10:33
@nineteen88 nineteen88 self-assigned this May 2, 2025
@nineteen88 nineteen88 force-pushed the storybook-to-vite branch from 44059a2 to d3f3f7f Compare May 2, 2025 12:35
@nineteen88 nineteen88 force-pushed the storybook-to-vite branch from 981881e to 2f08407 Compare May 15, 2025 14:07
@nineteen88 nineteen88 requested review from Parsium and edleeks87 May 15, 2025 14:26
Parsium
Parsium reviewed May 20, 2025
View reviewed changes
edleeks87
edleeks87 reviewed May 20, 2025
View reviewed changes
Copy link
Contributor

@edleeks87 edleeks87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing more from me that @Parsium hasn't already raised

@nineteen88 nineteen88 force-pushed the storybook-to-vite branch from 54e758a to eaec69f Compare May 22, 2025 15:06
@nineteen88 nineteen88 marked this pull request as ready for review May 22, 2025 15:24
@nineteen88 nineteen88 requested review from a team as code owners May 22, 2025 15:24
edleeks87
edleeks87 previously approved these changes May 23, 2025
View reviewed changes
Parsium
Parsium previously approved these changes May 27, 2025
View reviewed changes
@nineteen88 nineteen88 force-pushed the storybook-to-vite branch from eaec69f to 8acd2bd Compare May 27, 2025 10:28
@nineteen88 nineteen88 marked this pull request as draft May 27, 2025 10:33
@nineteen88 nineteen88 marked this pull request as ready for review May 27, 2025 10:34
@nineteen88
build(storybook): configure storybook to use vite instead of webpack
abc09b1 
- update welcome pages to be .jsx
- configure main.ts for the vite config
- add a vite.config file
@nineteen88 nineteen88 dismissed stale reviews from Parsium and edleeks87 via 3a7e425 May 30, 2025 16:06
@nineteen88 nineteen88 force-pushed the storybook-to-vite branch from 8acd2bd to 3a7e425 Compare May 30, 2025 16:06
@nineteen88 nineteen88 requested a review from a team as a code owner May 30, 2025 16:06
@nineteen88 nineteen88 force-pushed the storybook-to-vite branch from 3a7e425 to 1fb2ea8 Compare May 30, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parsium Parsium Parsium left review comments

@edleeks87 edleeks87 edleeks87 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@nineteen88 nineteen88

Labels
No UX QA Required Passed Review Pending QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nineteen88 @Parsium @edleeks87