Skip to content

chore: replace babel build with rollup and swc #7323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

edleeks87
Copy link
Contributor

@edleeks87 edleeks87 commented May 2, 2025

Proposed behaviour

Removes build.js script
Most babel dependencies and config are still needed for storybook @babel/cli has been removed.
Adds script to generate package.json files for lib directory to point to related esm modules
Adds script to move checker.svg from SimpleColor
Adds Rollup config to bundle and swc to compile code, add visualisation for bundle size comparison
swc and bundle-stats added to .gitignore

Current behaviour

babel is used to transpile code as part of a custom build script

Checklist

  • Commits follow our style guide
  • Typescript d.ts file added or updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

I have created https://github.com/edleeks87/dynamic-build-test (let me know if you haven't been invited)
I will cut a beta tag and help whoever tests this set it up the test bed but if you want to test it whilst you review message me and I'll explain it

alternatively you can use that beta version in a stackblitz here

@edleeks87 edleeks87 added DO NOT MERGE Work in progress This is a WIP PR so may not be ready for review labels May 2, 2025
@edleeks87 edleeks87 self-assigned this May 2, 2025
@edleeks87 edleeks87 force-pushed the rewrite-build branch 3 times, most recently from 9d38272 to 082da01 Compare May 7, 2025 15:12
@edleeks87 edleeks87 force-pushed the rewrite-build branch 2 times, most recently from 1aa6717 to b72149b Compare May 8, 2025 10:48
@Parsium Parsium requested review from Parsium and nineteen88 May 8, 2025 12:44
edleeks87 added 3 commits May 20, 2025 15:25
Removes `build.js` script
Most `babel` dependencies and config are still needed for `storybook`
`@babel/cli` has been removed
Parsium
Parsium previously approved these changes May 21, 2025
nineteen88
nineteen88 previously approved these changes May 21, 2025
@edleeks87 edleeks87 marked this pull request as ready for review May 21, 2025 14:28
@edleeks87 edleeks87 requested review from a team as code owners May 21, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants