-
Notifications
You must be signed in to change notification settings - Fork 83
chore: replace babel build with rollup and swc #7323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
edleeks87
wants to merge
4
commits into
master
Choose a base branch
from
rewrite-build
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d38272
to
082da01
Compare
1aa6717
to
b72149b
Compare
Parsium
reviewed
May 19, 2025
Removes `build.js` script Most `babel` dependencies and config are still needed for `storybook` `@babel/cli` has been removed
Parsium
previously approved these changes
May 21, 2025
nineteen88
previously approved these changes
May 21, 2025
Parsium
approved these changes
May 21, 2025
nineteen88
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Removes
build.js
scriptMost
babel
dependencies and config are still needed forstorybook
@babel/cli
has been removed.Adds script to generate package.json files for
lib
directory to point to relatedesm
modulesAdds script to move
checker.svg
fromSimpleColor
Adds Rollup config to bundle and
swc
to compile code, add visualisation for bundle size comparisonswc
andbundle-stats
added to.gitignore
Current behaviour
babel
is used to transpile code as part of a custom build scriptChecklist
d.ts
file added or updated if requiredQA
Additional context
Testing instructions
I have created https://github.com/edleeks87/dynamic-build-test (let me know if you haven't been invited)
I will cut a beta tag and help whoever tests this set it up the test bed but if you want to test it whilst you review message me and I'll explain it
alternatively you can use that beta version in a stackblitz here