Skip to content

chore(storybook): install addon interactions, test and pseudo packages #7346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2025

Conversation

DipperTheDan
Copy link
Contributor

@DipperTheDan DipperTheDan commented May 21, 2025

Proposed behaviour

  • Install Storybook's addon-interactions, test, test-runner and pseudo packages.
  • Introduce a user-interaction pause util to mimic the way a user would pause between interactions.
  • Add a couple of examples in to Action Popover and Button test folders. Please note, this is purely so that QA can test that installing these packages allows the play functions to work and will not negatively impact our current Storybook implementation. It is also necessary to ensure that Chromatic captures these stories correctly

Current behaviour

We currently do not have the necessary packages to run play functions in our implementation of Storybook

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

N/A

Testing instructions

  • Storybook should still work as usual.
  • Chromatic should capture the new examples at the end of the play function.
  • The new examples (ActionPopover -> test -> "ActionPopoverClick" & "ActionPopoverSubmenuClick" ) should work as expected.
  • The new examples (Button -> test -> "ButtonClick" & "ButtonHover" ) should work as expected.

nineteen88
nineteen88 previously approved these changes May 27, 2025
@DipperTheDan DipperTheDan marked this pull request as ready for review May 28, 2025 07:20
@DipperTheDan DipperTheDan requested review from a team as code owners May 28, 2025 07:20
@DipperTheDan DipperTheDan force-pushed the FE-7237_storybook-play-functions-installation branch from 4602a72 to f7bc9ce Compare May 30, 2025 07:54
@DipperTheDan DipperTheDan merged commit 2e78315 into master May 30, 2025
28 checks passed
@DipperTheDan DipperTheDan deleted the FE-7237_storybook-play-functions-installation branch May 30, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants