fix: incsearch flickering when typing characters during search #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the decoration provider on every renderer:draw() command caused flickering of incsearch highlights when showing completions for / and ? search modes on the cmdline as characters were typed. Decoration providers only need to be set once and they remain active, so the fix here is create it when the renderer is created and remember the last bufnr that was drawn to, along with the columns. Fixes Saghen#1061
jdrouhard
force-pushed
the
fix-cmdline-flicker
branch
from
d50e8cf to
d39a45b
Compare
|
Thank you! Seems like a nasty one so I really appreciate you taking the time to debug this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the decoration provider on every renderer:draw() command caused flickering of incsearch highlights when showing completions for / and ? search modes on the cmdline as characters were typed.
Decoration providers only need to be set once and they remain active, so the fix here is create it when the renderer is created and remember the last bufnr that was drawn to, along with the columns.
Fixes #1061