Improve Android build prereq checks and add build.sh#6
Open
gvago wants to merge 1 commit intoSagiMedina:mainfrom
Open
Improve Android build prereq checks and add build.sh#6gvago wants to merge 1 commit intoSagiMedina:mainfrom
gvago wants to merge 1 commit intoSagiMedina:mainfrom
Conversation
build-aar.sh now checks for Java, validates JDK version (auto-selects JDK 17 if a too-new JDK is default), auto-installs missing SDK platform 26, and adds GOPATH/bin to PATH for gomobile. New android/build.sh wraps the full build: generates local.properties, selects JDK 17, builds the Go bridge if needed, assembles the APK, and installs on a connected device. Replaces a multi-step manual process with a single command. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
SagiMedina
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-aar.shnow validates Java is installed and version is compatible (auto-selects JDK 17 if default JDK is too new)GOPATH/binto PATH so gomobile is found aftergo installandroid/build.shone-command build: generateslocal.properties, selects JDK, builds Go bridge if needed, assembles APK, and installs on a connected deviceBefore this change, building from scratch required manually installing JDK 17, NDK, SDK platform 26, creating
local.properties, and running 3 separate commands. Now it's justcd android && ./build.sh.Test plan
cd android/gobridge && ./build-aar.shon a machine with JDK 26 as defaultcd android && ./build.shfrom a clean state (nolocal.properties, no cached builds)🤖 Generated with Claude Code