Skip to content

fix: add httpx to core dependencies (fixes #5)#6

Open
sumaiya1303 wants to merge 1 commit into
Sahil170595:mainfrom
sumaiya1303:fix/httpx-missing-requirements
Open

fix: add httpx to core dependencies (fixes #5)#6
sumaiya1303 wants to merge 1 commit into
Sahil170595:mainfrom
sumaiya1303:fix/httpx-missing-requirements

Conversation

@sumaiya1303

Copy link
Copy Markdown

Summary

Adds httpx>=0.25 to core dependencies in pyproject.toml.

Problem

src/python/banterhearts/demo_agent/agents/chimera_agent.py imports httpx
at line 8 unconditionally. However httpx was only listed under optional
extras (bench, safety, resolve) — not in core dependencies.

A bare pip install chimeraforge never installs httpx, causing the
quick_start.md demo to fail immediately on every clean install with:

ModuleNotFoundError: No module named 'httpx'

Fix

Added httpx>=0.25 to the core dependencies block in pyproject.toml.

Related

Fixes #5

@Sahil170595

Copy link
Copy Markdown
Owner

Thanks for digging into this, @sumaiya1303 — the root-cause write-up on #5 is genuinely good, and the instinct behind this change is right. Two things worth separating:

1. The #5 repro specifically. The reproduction installs deps with pip install -r requirements.txt, but that file is a comment-only stub — it just points at the pyproject.toml extras and installs nothing. So the demo fails because no deps get installed at all, not because httpx is missing from the package metadata — and adding httpx to [project.dependencies] wouldn't make that exact repro pass, since the stub never installs the package. The actual quick-start fix is in #8 (switches the doc to pip install -e ".[bench]", which pulls httpx, and corrects the placeholder clone URL).

2. httpx as a core dependency — you're right. A plain pip install chimeraforge should leave the network-facing commands usable (the model-agnostic resolver, suggest, measure, safety, bench), and httpx doesn't affect offline plan even when it's installed — so there's a solid case for it being core, exactly as you have it here. Offline install for inspection is a real workflow and shouldn't leave half the CLI unusable.

How to take it to the finish line: two related PRs are in flight worth a skim first — #7 reworks the optional-dependency groups (and adds clean "install the extra" errors instead of raw tracebacks), and #8 fixes the #5 quick-start repro plus a quality_tier bug (#4). The cleanest version of your change, layered on that, would be: keep httpx in [project.dependencies] (as you have it) and trim the now-redundant [resolve]/[safety] extras (they'd collapse to just httpx).

Would you like to take it there? Happy to help you rebase onto #7 so they don't collide, and we'll land it with your name on it. Either way — thanks for jumping in, and please keep them coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] httpx missing from requirements.txt - quick_start.md demo_agent fails on clean install

2 participants