fix: add httpx to core dependencies (fixes #5)#6
Conversation
|
Thanks for digging into this, @sumaiya1303 — the root-cause write-up on #5 is genuinely good, and the instinct behind this change is right. Two things worth separating: 1. The #5 repro specifically. The reproduction installs deps with 2. httpx as a core dependency — you're right. A plain How to take it to the finish line: two related PRs are in flight worth a skim first — #7 reworks the optional-dependency groups (and adds clean "install the extra" errors instead of raw tracebacks), and #8 fixes the #5 quick-start repro plus a Would you like to take it there? Happy to help you rebase onto #7 so they don't collide, and we'll land it with your name on it. Either way — thanks for jumping in, and please keep them coming. |
Summary
Adds
httpx>=0.25to core dependencies inpyproject.toml.Problem
src/python/banterhearts/demo_agent/agents/chimera_agent.pyimportshttpxat line 8 unconditionally. However
httpxwas only listed under optionalextras (
bench,safety,resolve) — not in core dependencies.A bare
pip install chimeraforgenever installs httpx, causing thequick_start.md demo to fail immediately on every clean install with:
ModuleNotFoundError: No module named 'httpx'
Fix
Added
httpx>=0.25to the coredependenciesblock inpyproject.toml.Related
Fixes #5