Add descriptive alt text to landing page images - #113
Conversation
|
@agarwalpranav0711 is attempting to deploy a commit to the Sahil's projects Team on Vercel. A member of the Team first needs to authorize it. |
Summary of ChangesHello @agarwalpranav0711, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the accessibility and search engine optimization of the application's landing page. By implementing more descriptive Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request improves accessibility by adding more descriptive alt text to images, which is a great initiative. The change to the logo's alt text in Hero.jsx makes it more specific and is a clear improvement. For the TravelStoryCard.jsx component, I've added a suggestion to make the alt text more concise to avoid redundancy for screen reader users, which aligns with accessibility best practices. Overall, these are positive changes for the user experience.
| <img | ||
| src={imgUrl} | ||
| alt={title} | ||
| alt={`Travel story image: ${title}`} |
There was a problem hiding this comment.
While adding more context to alt text is a good goal, prefixes like "Image of" or, in this case, "Travel story image:" are generally discouraged as per accessibility best practices. Screen readers already announce that the element is an image, so this can lead to redundant announcements (e.g., "Image, Travel story image: [title]"). Using just the title is more concise and provides a better user experience, assuming the title itself is descriptive.
| alt={`Travel story image: ${title}`} | |
| alt={title} |
What this PR does
alttext to images on the landing pageWhy this change is needed
Related Issue
Closes #112