Add social media icons to ContributorsFooter - #123
Conversation
Added social media icons (GitHub, LinkedIn, X, and Website) to the ContributorsFooter component. Includes hover effects for better UI consistency.
|
@ParthBhuptani is attempting to deploy a commit to the Sahil's projects Team on Vercel. A member of the Team first needs to authorize it. |
Summary of ChangesHello @ParthBhuptani, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR adds social media icons (GitHub, LinkedIn, X, Website) to the Contributors page footer to maintain consistency with the Landing page footer, addressing issue #108. The implementation adds a social links configuration array and ensures the icons are rendered in the footer with appropriate hover effects and accessibility attributes.
Changes:
- Added imports for
FaGlobeandFaXTwittericons - Extended the
socialLinksarray with LinkedIn, X (Twitter), and Website entries - Removed unused
FaTwitterimport
There was a problem hiding this comment.
Code Review
This pull request adds social media icons to the ContributorsFooter. The implementation is straightforward, but there are a couple of critical syntax errors due to missing quotes in the socialLinks array that will break the component. I've provided suggestions to fix them. Additionally, I've included a medium-severity suggestion to improve maintainability by centralizing the hardcoded URLs.
|
Hi @Sahilll94 , I have resolved the merge conflicts and addressed the syntax issues mentioned in the review. kindly review when you get time. Thank you! |
This PR adds social media icons (GitHub, LinkedIn, X, Website) to the ContributorsFooter.
Changes:
This follows the maintainer's note regarding adding social links to the contributors footer.
Closes #108