Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flag to strip metadata #281

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

SalOne22
Copy link
Owner

@SalOne22 SalOne22 commented Nov 30, 2024

@Mikachu2333 hi, sorry for the long time that I didn't work on this project, this would be the last PR before release of v0.11.0. Please check that metadata (ICC, EXIF) are preserved by default for supported codecs and images are not corrupted

@SalOne22 SalOne22 requested a review from Mikachu2333 November 30, 2024 11:28
@SalOne22 SalOne22 linked an issue Nov 30, 2024 that may be closed by this pull request
@Mikachu2333
Copy link
Collaborator

preserved by default

Should we consider removing these infos as the default option? Because I remember you once said that rimage would remove those infos automatically due to privacy concerns.

@SalOne22
Copy link
Owner Author

SalOne22 commented Dec 3, 2024

Because I remember you once said that rimage would remove those infos automatically due to privacy concerns

This PR is applicable only for ICC and EXIF metadata. I don't see any issues with privacy in that. All other metadata are getting stripped

Copy link
Collaborator

@Mikachu2333 Mikachu2333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not prevent exif info from removing by default setting.
Situation 1: png -> moz
./rimage moz ./exif.png -s "_after"
图片
图片

Situation 2: png -> jpeg
./rimage jpeg ./exif.png -s "_after"
Failed without icc tag and exif infos

Situation 3: png -> png
./rimage png ./exif.png -s "_after"
Failed without icc tag and exif infos

Situation 4: jpg -> png
./rimage png ./color.jpg -s "_after"
Success, but exif infos are missing and the icc info would be cov to rgb (the original icc tag would be removed by default)

Situation 5: jpg -> jpg
./rimage png ./color.jpg -s "_after"
Success, but exif infos are missing and the icc info would be cov to rgb (the original icc tag would be removed by default)

test.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add flag to preserve metadata
2 participants