Skip to content
This repository was archived by the owner on Mar 9, 2021. It is now read-only.

Applies $scriptpath variable loading in psake.ps1.#21

Open
fabriciomurta wants to merge 9 commits intoroslynfrom
roslyn
Open

Applies $scriptpath variable loading in psake.ps1.#21
fabriciomurta wants to merge 9 commits intoroslynfrom
roslyn

Conversation

@fabriciomurta
Copy link

This same approach is already used in the SaltarelleCompiler's 'psake.ps1' script.

@erik-kallen
Copy link
Contributor

Sorry, but this pull request is to big, and it contains changes with which I disagree.

  1. packages/ content. I prefer to have these files committed; I realize there is a tradeoff, but I like being able to clone a repo and then have everything I need to build it. Especially in this case, where there are dependencies that are not on nuget.org (the compiler alpha packages).
  2. .gitattributes (though it doesn't really matter) IMO this should be set by default in all git installations.
  3. Hardcoded version. If you want an alpha build, create a tag called 3.0-alpha.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants