Added dashboard restriction into RBAC system#21
Open
hfehrmann wants to merge 1 commit intoSamAthanas:mainfrom
Open
Added dashboard restriction into RBAC system#21hfehrmann wants to merge 1 commit intoSamAthanas:mainfrom
hfehrmann wants to merge 1 commit intoSamAthanas:mainfrom
Conversation
There is a bug in the current implementation, where if a user has selected a dashboard that is blocked by the RBAC system, the UI doesn't load for them. Current implementation doesn't restrict the dashboard election for the user
Owner
|
Hey @hfehrmann, thank you for your contribution! This is a great idea. I just tested your code locally and it seems to not be compatible with the previous configuration, hiding all the panels including the main dashboard. Heres a screenshot of what I am seeing on my side: If the panel config is empty, can we show all panels by default? |
Author
|
@SamAthanas Oh! I'm gonna try to see how the system Having said that, does the role you are showing blocks by default? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Warning
There is a bug in the current implementation, where if a user has selected a dashboard that is blocked by the RBAC system, the UI doesn't load for them. Current implementation doesn't restrict the dashboard election for the user
Follow up on #20
Adds the capability of restricting dashboards for the user. This implementation attaches itself into the WebsScket API for the panels endpoint.
Giving that the frontend handles the routing logic using the results from that endpoint, a user cannot access a restricted dashboards even if they put the exact match into the URL.
I'm not sure if this is up to standard for the repo