Skip to content

Commit

Permalink
Upgrad to run on Laravel 5 and Facebook PHP SDK v4.1
Browse files Browse the repository at this point in the history
  • Loading branch information
SammyK committed Feb 13, 2015
1 parent 0eac815 commit 4ea5815
Show file tree
Hide file tree
Showing 19 changed files with 628 additions and 526 deletions.
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ before_script:
- composer install --prefer-source --no-interaction --dev

script:
- phpunit --coverage-text
- ./vendor/bin/phpunit --coverage-text
- ./vendor/bin/phpcs src --standard=psr2

matrix:
allow_failures:
Expand Down
12 changes: 11 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,19 @@
# CHANGELOG


## 2.0.0 - TBD
## 2.0.0 - February 13, 2015

- Upgraded to work on Laravel 5! Yay!
- Upgraded to use the latest Facebook PHP SDK v4.1.
- Removed the [Facebook Query Builder](https://github.com/SammyK/FacebookQueryBuilder) dependency.
- Removed the migration stub since there's only one column we need to add for most cases.
- Removed the config, route & view for the `channel.html` since that seems to be deprecated.
- Renamed `FacebookableTrait` to `SyncableGraphNodeTrait` since the Graph API returns nodes, not objects.
- Renamed `createOrUpdateFacebookObject()` to `createOrUpdateGraphNode()` since that makes more since on Facebook's domain.
- Added support for re-requests and re-authentications.
- Removed `LaravelFacebookSdkException` to let all the native PHP SDK's exceptions fall through.
- Removed all the weird authentication crap that didn't make any sense.
- Bound the package to the IoC container as `SammyK\LaravelFacebookSdk\LaravelFacebookSdk` instead of the old `facebook-query-builder`.


## 1.1.1 - December 11, 2014
Expand Down
26 changes: 22 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
Contributing
============
# Contributing

Contributions are **welcome** and will be fully **credited**.

We accept contributions via Pull Requests on [Github](https://github.com/SammyK/LaravelFacebookSdk).


Pull Requests
-------------
## Pull Requests

- **[PSR-2 Coding Standard](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md)** - Unlike Laravel, the LaravelFacebookSdk follows PSR-2. The easiest way to apply the conventions is to install [PHP Code Sniffer](http://pear.php.net/package/PHP_CodeSniffer).

- **Add tests!** - Your patch won't be accepted if it doesn't have tests. And the tests must pass of course.

Expand All @@ -21,5 +21,23 @@ Pull Requests

- **Send coherent history** - Make sure each individual commit in your pull request is meaningful. If you had to make multiple intermediate commits while developing, please squash them before submitting.

- **Ensure tests pass!** - Please run the tests (see below) before submitting your pull request, and make sure they pass. We won't accept a patch until all tests pass.

- **Ensure no coding standards violations** - Please run PHP Code Sniffer using the PSR-2 standard (see below) before submitting your pull request. A violation will cause the build to fail, so please make sure there are no violations. We can't accept a patch if the build fails.


## Running Tests

``` bash
$ ./vendor/bin/phpunit
```


## Running PHP Code Sniffer

``` bash
$ ./vendor/bin/phpcs src --standard=psr2 -sp
```


**Happy coding**!
Loading

0 comments on commit 4ea5815

Please sign in to comment.