-
Notifications
You must be signed in to change notification settings - Fork 130
minecraft/protocol: Fix some packets #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packet.UpdateSubChunkBlocksCo-Authored-By: Liliya233 <[email protected]>
…ntity` Co-Authored-By: Liliya233 <[email protected]>
Co-Authored-By: Liliya233 <[email protected]>
Co-Authored-By: Liliya233 <[email protected]>
Co-Authored-By: Liliya233 <[email protected]>
Co-Authored-By: Liliya233 <[email protected]>
…ionType` Co-Authored-By: Liliya233 <[email protected]>
Co-Authored-By: Liliya233 <[email protected]>
Co-Authored-By: Liliya233 <[email protected]>
Co-Authored-By: Liliya233 <[email protected]>
Co-Authored-By: Liliya233 <[email protected]>
|
All right, and ready for review. |
|
Most changes are come from @CoozillaX, and I just compare these changes with documents which wrote by Mojang. |
|
Is this pull request still considered? Has it been forgotten? |
TwistedAsylumMC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things that I do not believe to be correct. I have gone over everything whilst looking at multiple sources + looking deeper into BDS. The docs are not a 100% reliable source so unless you can prove that the things I've commented on are actually correct, they should be reverted
|
All conversations have been solved, and ready for merge. |
|
I confirmed everything again with the new docs, and my changes are still correct with current/latest mc version. The following packets are failed to confirm due to the new docs not record them.
|
|
Hello, is there anything I have not done with this pull request? If so, please tell me so I can start to work on it. (This PR takes about 3 month and still not merge) |
|
Apologies for taking a while to merge this, I completely forgot about it. Thanks for all the work! |
|
You are welcome. |
This pull request fix so many packets (the data type for some fields), and the following is the reference list.
Note that when this pull request merged, #209 also can be closed.
See UpdateSubChunkBlocks, and you can find that the data type for
Positionisprotocol.BlockPoswhich encoding byio.UBlockPos.See PlayerAuthInput and PackedItemUseLegacyInventoryTransaction, and you can find that the correct marshal for field
BlockPositionisio.UBlockPos.See AddVolumeEntity, RemoveVolumeEntity and EntityNetId, and you can find that the data type for
EntityRuntimeIDisuint32whcih encoding byio.Varuint32.See AgentActionEvent and int, and you can find that the data type for
Actionisint32which encoding byio.Int32.See ChangeMobProperty and ActorUniqueID, and you can find that the data type for
EntityUniqueIDisint64which encoding byio.Varint64.See CommandBlockUpdate, and you can find that the data type for
TickDelayisuint32 (unsigned int)which encoding byio.Uint32.See LessonProgress, and you can find that the data type for
Actionisint32which encoding byio.Varint32.See OnScreenTextureAnimation, and you can find that the data type for
AnimationTypeisuint32 (unsigned int)which encoding byio.Uint32.See RequestChunkRadius, and you can find that the data type for
MaxChunkRadiusisbytewhich encoding byio.Uint8.See RequestPermissions, and you can find that the data type for
PermissionLevelisint32which encoding byio.Varint32.See SimpleEvent, and you can find that the data type for
EventTypeisuint16 (unsigned short)which encoding byio.Uint16.See StartGame which path is
StartGamePacket/Settings (LevelSettings)and LevelSettings which path isLevelSettings/override force experimental gameplay has value, and you can find that the data type forForceExperimentalGameplayisboolwhich encoding byio.Bool.See LegacyTelemetryEventPacket, and you can find that the event which named
AgentCreatedhas no data, but missing marshal in gophertunnel.See PlayerArmorDamagePacket, and you can find that the data type for
ArmourSlotisint32which encoding byio.Varint32. Or you can look up this image.