fix: guard against raising None when Bedrock retries are exhausted#15
Merged
Conversation
If _max_retries is 0 the retry loop never runs and last_exc stays None, so the for-else branch would execute 'raise None' and surface as a bare TypeError. Raise a descriptive RuntimeError instead and drop the 'type: ignore' that was masking the narrowing gap. Resolves CodeQL py/illegal-raise (alert #23).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In the retry loop's
for/elsebranch,last_exccan still beNonewhenmax_retries=0, soraise last_excwould surface as a bareTypeError. This adds an explicit guard raising a descriptiveRuntimeError, and removes thetype: ignore[misc]that was masking the type-narrowing gap.Why
Resolves CodeQL
py/illegal-raise(alert #23). No behavior change on any path where a retryable exception was captured.