Make the data operation window resizable and update documentation #3755
Conversation
rozyczko
left a comment
rozyczko
left a comment
There was a problem hiding this comment.
I am not sure this does the resizing properly.
Only the middle chart is actually getting resized and it doesn't look good
|
I see the same problem as @rozyczko in resizing on Windows |
|
This should resize properly now |
|
@rozyczko Thanks for the help. I tried it on my machine and it's working as it should do, for both the windows installer and the dev version. @drnpaul I saw that on some machines is working as I was expecting (on mine and the one of @conanr-create for instance), but in other cases, like yours, not. Honestly, I don't have an explanation for that. |
Cristian2299
force-pushed
the
3752_Data_Operation_tool_window_not_resizable
branch
from
2204c98 to
af93b6a
Compare
…://github.com/sasview/sasview into 3752_Data_Operation_tool_window_not_resizable
krzywon
left a comment
krzywon
left a comment
There was a problem hiding this comment.
Major improvement to the data operation panel! Tested locally and all 3 data panels expand equally. I like the new left-to-right flow of the window (as it should be), and the ability to preview the resulting data set before sending it to the data explorer.
|
|
||
| 6) If the operation is successful, hit the Apply button to make the new dataset. | ||
| The new dataset will appear in the *Data Explorer*. | ||
| 6) If the operation is successful, hit the Compute button to make appear a preview of the new dataset. |
There was a problem hiding this comment.
Nitpicky wordsmithing:
6) If the data matching operation is successful, hitting the Compute button will generate a preview of the new dataset, but, unlike previous versions, will not generate an analyzable data set.
| layout = QtWidgets.QVBoxLayout() | ||
| # FIXME setMargin -> setContentsMargins in qt5 with 4 args | ||
| #layout.setContentsMargins(0) | ||
| layout.setSpacing(0) |
There was a problem hiding this comment.
This doesn't seem to effect anything, but it seems out of scope for this PR.
There was a problem hiding this comment.
I had a chance to do a deepish dive into a functionality review and have the following comments:
The separation of computing from saving is a nice however I find it a bit confusing
- the tool tip on
Computesays "Generate the Data and send to Data Explorer" However it only seems to generate the result plot in the panel (so it does "Generate the Data") but nothing shows up in the data explorer until I hitSave. I think the behavior is what you wanted by reading the documentation but the tool tip should be changed then to say "Generate the Data" or maybe even "Generate the new data" - The
Savebutton does not have any tool tip (nor doesResetfor that matter). Here you could add "send the computed data to the Data Explorer" maybe? - Hitting
Savewithout hitting compute appears to do the computation then send that to theData Explorerwhere it shows up. I like the idea thatSavedoes both if computed was not clicked first. It means it can be done in one step instead of two if desired. However the computed result is never displayed. If it computes the data before sending it to theData Explorer(and I checked that seems to be what it is doing) it should also display the results in the 3 box I think.
Some other things probably for another PR and not for this?
- It would be really great if instead of always insisting on a new name, there was an option to click that would allow overwriting (replacing the data with the same name with the new computed data of that name) just like the model editors all have.
- When operating on 2D data I note that the resulting 2D data keeps the title of the first of the two being added and that that title is used if you then try to plot the new resulting 2D data set. This is a bit confusing since plots of that first 2D data and of the date resulting from the data operations will have the same plot title. This is an issue that predates this PR so probably we should just put in another issue for this unless the solution is easy and obvious.
- It is a bit irritating that if one wants to subtract a flat background for example, or any time one choose to have a number as the second term in the operation, the validation tool seems to check at every key stroke and thus often throws errors that are not errors. For example, typing 1.0e-2 will throw 2 errors. The first when e is typed and again when - is typed. Once 2 is typed it becomes happy again. Again, this predates this PR and if not easy and obvious should not get in the way of merging this PR. However it should be submitted as a new issue in that case
|
I forgot to mention that I am only able to resize the |
Description
The window of Data Operation utility is now resizable and the order of "Data1", "Data2", and "Output Data" has been change to have the output on the right. The modifications only concerns the UI. The documentation has been updated with a screenshot of the new layout.
Fixes #3752
How Has This Been Tested?
Tested on windows 10. Tested with example files and experimental data set. Operation and output results works as expected.
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)