Skip to content

fixed disconnect logic with the proper PySide6 signal checking method. #3771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixed disconnect logic with the proper PySide6 signal checking method. #3771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 6 additions & 19 deletions src/sas/qtgui/Perspectives/Fitting/ConstraintWidget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,27 +234,14 @@ def updateSignalsFromTab(self, tab=None):
tab_object = ObjectLibrary.getObject(tab)

# Disconnect all local slots, if connected
# None of the methods below seem to work with Qt6.2.4
# 1.
# if tab_object.receivers(tab_object.newModelSignal) > 0:
# 2.
# newModelSignal =QtCore.QMetaMethod.fromSignal(tab_object.newModelSignal)
# if tab_object.isSignalConnected(newModelSignal):
# 3.
# m_obj = tab_object.metaObject()
# is_connected = m_obj.isSignalConnected(m_obj.method(m_obj.indexOfSignal("newModelSignal()")))

try:
# Using isSignalConnected() with QMetaMethod (works with PySide6 6.9.1+)
newModelSignal = QtCore.QMetaMethod.fromSignal(tab_object.newModelSignal)
if tab_object.isSignalConnected(newModelSignal):
tab_object.newModelSignal.disconnect()
except RuntimeError:
# need to pass here since no known PySide6 method of checking if signal is connected
# seems to work here. Need to upgrade to more recent version of PySide6 but this
# currently causes other issues.
pass
try:

constraintAddedSignal = QtCore.QMetaMethod.fromSignal(tab_object.constraintAddedSignal)
if tab_object.isSignalConnected(constraintAddedSignal):
tab_object.constraintAddedSignal.disconnect()
except RuntimeError:
pass

# Reconnect tab signals to local slots
tab_object.constraintAddedSignal.connect(self.initializeFitList)
Expand Down