Skip to content

Conversation

@dehoni
Copy link
Contributor

@dehoni dehoni commented Nov 17, 2025

Description

onPolyComboIndexChange takes the parameter name as thickness[n] instead of the correct value, e.g. for shell 2 this should be thickness2, such that sasmodels can handle it. A fix needs to ensures to pass on an expanded parameter name like thickness2 to kernel_module.set_dispersion instead of the thickness[n] which triggered the ValueError.

Fixes #3741

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error for dispersity for multishell modells

2 participants