feat!: change early-exit to allow individual triggers#385
Open
RobertMueller2 wants to merge 1 commit intoSatty-org:mainfrom
Open
feat!: change early-exit to allow individual triggers#385RobertMueller2 wants to merge 1 commit intoSatty-org:mainfrom
RobertMueller2 wants to merge 1 commit intoSatty-org:mainfrom
Conversation
RobertMueller2
force-pushed
the
early-exit-copy
branch
from
472c344 to
1f80e86
Compare
RobertMueller2
force-pushed
the
early-exit-copy
branch
from
1f80e86 to
cc4a56a
Compare
RobertMueller2
force-pushed
the
early-exit-copy
branch
from
cc4a56a to
fd74432
Compare
RobertMueller2
force-pushed
the
early-exit-copy
branch
from
fd74432 to
0947589
Compare
Member
|
My mind model here was:
Would the solution not be to just ensure that all actions are properly run before exiting and therefore only keeping one single "early exit flag"? |
Closes: Satty-org#152 This allows the following configs early-exit = true early-exit = [ "all" ] early-exit = [ "copy", "save", "save-as" ] as well as command line --early-exit --early-exit=all --early-exit=copy,save,save-as
RobertMueller2
force-pushed
the
early-exit-copy
branch
from
0947589 to
63c0462
Compare
RobertMueller2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #152
This allows the following configs
as well as command line