feat: add pixelate and pseudo-pixelate#469
Open
RobertMueller2 wants to merge 3 commits intoSatty-org:mainfrom
Open
feat: add pixelate and pseudo-pixelate#469RobertMueller2 wants to merge 3 commits intoSatty-org:mainfrom
RobertMueller2 wants to merge 3 commits intoSatty-org:mainfrom
Conversation
Member
Author
|
for brighter images, the "independent mode" result is a bit too bright. Maybe the weighting math isn't great yet. EDIT: need to divide everything by two if I have a a horizontal and a vertical influence, they each add to 1. that looks a lot better. Unfortunately, now I have to redo the recording. |
863d1f5 to
5313f33
Compare
Member
Author
|
Perhaps we also really need to call this "pseudo-pixelate", no need to re-invent lingo? 😉 |
Closes: Satty-org#90 This implements a pixelate tool with two modes - regular mode with a normal block pixelation, this is, depending on selected area and image resolution, reversible - "independent mode" that takes data from outside the selected area, the area is entirely overwritten by this. Then, the regular pixelation creates a block-pixelate look. Some things are still open: [ ] figure out a better icon - help needed please [ ] reach out to flameshot guys regarding credits [ ] figure out if BLOCKSIZE is good at a value of 32. This may actually need to be adjustable. Known limitations: - in independent mode, canvas background may contribute to the mix of pixels if the selection is started at image origin - in idependent mode, if the selection "leaves" Satty's window, nothing happens. We would be lacking one fringe in that instance. This PR was inspired by - https://github.com/flameshot-org/flameshot/pull/3765/changes - Satty-org#468 by kikeijuu (superseded by this PR) Regarding the credits, the idea with taking "fringes" was taken from said PR, but I reimplemented the gist of it according to my understanding. I did, for example, skip any additional noise which might be suitable for adding later. Also, actually iterating the source and target data works a bit different due to the objects used. I don't think we need to talk about a separate licence for this bit, but we'll see what the flameshot guys say about this.
88b650e to
05a65bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #90
This implements a pixelate tool with two modes
Some things are still open:
Known limitations:
This PR was inspired by
Regarding the credits, the idea with taking "fringes" was taken from said PR, but I reimplemented the gist of it according to my understanding. I did, for example, skip any additional noise which might be suitable for adding later. Also, actually iterating the source (fringes) and target data (overwritten area) works a bit different due to the objects used. I don't think we need to talk about a separate licence for this bit, but we'll see what the flameshot guys say about this.
pixelation2.mp4