Testcase#88
Merged
Just-Here-TO-Code merged 3 commits intodevfrom Mar 30, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands the app’s scenario/testcase system and UI, while also introducing multiple physics/rendering upgrades (constraints rendering, velocity arrows, buoyancy, updated collision/manifold code).
Changes:
- Reworks the UI flow in
renderer/window.cpp(start screen/guide/menu bar) and adds theming/font loading. - Refactors/extends scenarios (
TestCaseenum + scenario loader now returns aCamera) and adds new “chapterwise” scenario mappings. - Updates physics engine internals (manifold/contact structures, constraint solving, collision manifold builders) and adds buoyancy support.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vcpkg.json | Removes slint dependency from manifest. |
| renderer/window.cpp | Adds multi-screen UI flow, scenario selection, gravity presets, and camera input gating. |
| renderer/drawconstraints.hpp | Declares constraint rendering entry points. |
| renderer/drawconstraints.cpp | Implements solid/wire rendering for distance constraints. |
| renderer/drawbodies.hpp | Adds API to toggle velocity arrow visibility. |
| renderer/drawbodies.cpp | Adds rotated body rendering, constraint rendering hooks, and velocity arrows. |
| renderer/camera.hpp | Adds fluent setters for camera properties. |
| renderer/bodyshaders.cpp | Extends fragment shader with material/fog + adds shader compile/link logging. |
| renderer/bodymenu.hpp | Splits body menu into reusable sub-panels + popup/toast API. |
| renderer/bodymenu.cpp | Implements menus for spawning, constraints, world settings, inspector, and toast popups. |
| renderer/aether_theme.hpp | Declares font/theme setup. |
| renderer/aether_theme.cpp | Loads default font (with Windows Segoe UI attempt) and applies ImGui theme. |
| engine/world/physicsworld.hpp | Adds delete-body/constraint APIs, lookup map/pointer sync helpers, buoyancy fields, and constraint accessors. |
| engine/world/physicsworld.cpp | Implements lookup syncing, body deletion, buoyancy integration, angular contact math, and constraint solver changes. |
| engine/responses.hpp | Adds PhysicsResult / PhysicsError for API results. |
| engine/math/quat.hpp | Adds Quat::fromAxisAngle. |
| engine/math/quat.cpp | Implements Quat::fromAxisAngle. |
| engine/engine_configs.hpp | Adds restitution threshold, buoyancy PI constant, and defines DEBUG_MODE. |
| engine/core/rigidbody.hpp | Minor include/format updates. |
| engine/core/rigidbody.cpp | Formatting + minor message/force accumulator cleanup. |
| engine/core/ramp_collider.hpp | Adds local center-of-mass offset helper. |
| engine/core/collider.hpp | Formatting + default ShapeType init. |
| engine/core/buoyancy.hpp | Adds buoyancy API and Fluid definition. |
| engine/core/buoyancy.cpp | Implements buoyancy force application for spheres/boxes. |
| engine/common_header.hpp | Pulls responses.hpp into common header. |
| engine/collision/obb.hpp | Adds OBB helpers used by manifold builders. |
| engine/collision/manifolds/buildSphereSphereManifold.cpp | Rewrites sphere-sphere manifold construction. |
| engine/collision/manifolds/buildRampSphereManifold.cpp | Refactors ramp-sphere manifold with local-space logic and robustness helpers. |
| engine/collision/manifolds/buildRampRampManifold.cpp | Refactors ramp-ramp manifold using SAT axes + multi-contact selection. |
| engine/collision/manifolds/buildRampBoxManifold.cpp | Refactors ramp-box manifold using OBB + SAT and candidate contacts. |
| engine/collision/manifolds/buildBoxSphereManifold.cpp | Rewrites box-sphere manifold using OBB projection. |
| engine/collision/manifolds/buildBoxBoxManifold.cpp | Updates box-box manifold for oriented boxes + candidate collection. |
| engine/collision/contactmanifold.hpp | Initializes IDs and formats struct. |
| engine/collision/contact.hpp | Adds rA/rB to contacts and initializes IDs. |
| app/test_scenarios.hpp | Replaces old testcase list; adds chapter map globals and returns Camera from loader. |
| app/test_scenarios.cpp | Adds new scenario implementations, initializes chapter map, and updates loader switch. |
| app/main.cpp | Removes hard-coded testcase selection; delegates to UI flow. |
| README.md | Adds “Quick Run” section for Windows/Linux releases. |
| CMakeSettings.json | Enables vcpkg manifest mode in VS CMake settings. |
| CMakeLists.txt | Adds new sources (buoyancy, drawconstraints, theme) to build. |
| .gitignore | Adds release exceptions and adjusts ignored build directories. |
Comments suppressed due to low confidence (1)
app/test_scenarios.cpp:374
spawn_box_ramp_casenow creates the ramp with a non-zero mass (2.0f). That makes the ramp dynamic, so it will fall under gravity and move during the scenario, which typically defeats the purpose of a ramp test setup. If the ramp is meant to be a static environment object, its mass should remain 0.0f.
world.addBody(Rigidbody(Vec3(-2.0f, 0.0f, 0.0f), Vec3(0.0f, 0.0f, 0.0f), &g_gentle_ramp, 2.0f));
world.addBody(Rigidbody(Vec3(0.5f, 4.0f, 0.0f), Vec3(0.0f, 0.0f, 0.0f), &g_small_box, 2.0f));
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@urastogi2048 good work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added testcases and organised chapterwise.
Changes Made
-Organised them chapterwise.
Implementation Details
Patched testscenario.cpp.
Checklist
Type: