Skip to content

fix : 선택모드 이후 사진 안보여지는이슈 수정#196

Merged
caseBread merged 1 commit intomainfrom
fix/select-mode
Mar 26, 2026
Merged

fix : 선택모드 이후 사진 안보여지는이슈 수정#196
caseBread merged 1 commit intomainfrom
fix/select-mode

Conversation

@caseBread
Copy link
Copy Markdown
Member

요약

  • 선택모드 이후 사진 안보여지는이슈 수정
  • 사소한 디자인 수정

구현 사항

  • [ ]
  • [ ]
  • [ ]
  • [ ]

📸 스크린샷

Need Review

  • ~ 부분 이렇게 구현했어요, 피드백 부탁해요!

Reference

📜 리뷰 규칙

Reviewer는 아래 P5 Rule을 참고하여 리뷰를 진행합니다.
P5 Rule을 통해 Reviewer는 Reviewee에게 리뷰의 의도를 보다 정확히 전달할 수 있습니다.

  • P1: 꼭 반영해주세요 (Comment)
  • P2: 적극적으로 고려해주세요 (Comment)
  • P3: 웬만하면 반영해 주세요 (Comment)
  • P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
  • P5: 그냥 사소한 의견입니다 (Approve)

@caseBread caseBread requested a review from dasosann March 26, 2026 01:44
@caseBread caseBread self-assigned this Mar 26, 2026
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fe Ready Ready Preview, Comment Mar 26, 2026 1:45am

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 선택 모드에서 사진이 보이지 않던 중요한 버그를 해결하고, 사용자 경험을 향상시키기 위한 작은 디자인 조정을 포함합니다. 주요 변경 사항은 PhotoList 컴포넌트의 사진 필터링 로직을 개선하여 현재 모드에 따라 사진이 올바르게 표시되도록 한 것입니다.

Highlights

  • 사진 표시 버그 수정: 선택 모드 이후 사진이 올바르게 표시되지 않던 문제를 수정했습니다.
  • 사소한 디자인 개선: 버튼의 배경색을 조정하는 등 사용자 인터페이스의 사소한 디자인을 개선했습니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@caseBread caseBread merged commit 675a78d into main Mar 26, 2026
4 checks passed
@caseBread caseBread deleted the fix/select-mode branch March 26, 2026 01:45
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the tertiary button fill color in globals.css to a specific hex value and modifies the PhotoList component to adjust photo filtering based on a new mode prop, allowing all photos to be displayed when the mode is 'default'. Feedback suggests that the hardcoded color value in globals.css should be replaced with an existing CSS variable (--color-neutral-50) to maintain design system consistency and improve maintainability.

--color-button-tertiary-border: var(--color-neutral-600);
--color-button-tertiary-fill-pressed: var(--color-neutral-0);
--color-button-tertiary-fill: var(--color-neutral-0);
--color-button-tertiary-fill: #f1f2f3;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

하드코딩된 색상 값 #f1f2f3 대신, 이미 정의된 CSS 변수 --color-neutral-50를 사용하는 것이 좋습니다. 이렇게 하면 색상 토큰 시스템의 일관성을 유지하고 향후 유지보수를 더 쉽게 할 수 있습니다.

  --color-button-tertiary-fill: var(--color-neutral-50);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant