Skip to content

Fix/selectmode tooltip#198

Merged
dasosann merged 8 commits intomainfrom
fix/selectmode-tooltip
Mar 26, 2026
Merged

Fix/selectmode tooltip#198
dasosann merged 8 commits intomainfrom
fix/selectmode-tooltip

Conversation

@dasosann
Copy link
Copy Markdown
Contributor

요약

구현 사항

  • 툴팁 선택모드에서 안보이게
  • 치즈네컷 버튼 누르면 툴팁 안보임
  • 전체선택 하고 토글 이동 시 사진 개수 반영
  • [ ]

📸 스크린샷

Need Review

  • ~ 부분 이렇게 구현했어요, 피드백 부탁해요!

Reference

📜 리뷰 규칙

Reviewer는 아래 P5 Rule을 참고하여 리뷰를 진행합니다.
P5 Rule을 통해 Reviewer는 Reviewee에게 리뷰의 의도를 보다 정확히 전달할 수 있습니다.

  • P1: 꼭 반영해주세요 (Comment)
  • P2: 적극적으로 고려해주세요 (Comment)
  • P3: 웬만하면 반영해 주세요 (Comment)
  • P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
  • P5: 그냥 사소한 의견입니다 (Approve)

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fe Ready Ready Preview, Comment Mar 26, 2026 6:42am

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 앨범 상세 화면의 사용자 경험을 개선하기 위한 여러 수정 사항을 포함합니다. 특히, 사진 선택 모드에서의 툴팁 동작을 더욱 직관적으로 만들고, 전체 사진 선택 시 성능을 최적화하여 사용자가 더 부드럽게 기능을 사용할 수 있도록 하였습니다. 또한, 앨범 상세 화면의 현재 모드 상태를 하위 컴포넌트들이 인지하고 적절히 반응하도록 데이터 흐름을 명확히 했습니다.

Highlights

  • 툴팁 가시성 개선: 선택 모드에서 불필요한 툴팁이 표시되지 않도록 수정하고, '네컷사진 확정하기' 버튼 클릭 시 툴팁이 사라지도록 개선했습니다.
  • 사진 전체 선택 로직 최적화: 전체 선택 시 사진 목록을 효율적으로 업데이트하기 위해 setSelectedPhotos 액션을 추가하고, 기존 addSelectedPhoto 반복 호출 대신 한 번에 모든 선택된 사진을 설정하도록 변경했습니다.
  • 모드 전달 구조 개선: 앨범 상세 화면의 모드(일반/선택) 정보를 하위 컴포넌트인 AlbumInfosAlbumBestCut으로 전달하도록 구조를 개선했습니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@dasosann
Copy link
Copy Markdown
Contributor Author

@gemini-code-assist review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a 'mode' prop to several album detail components (ScreenAlbumDetail, AlbumInfos, AlbumBestCut) to control their behavior, particularly for photo selection. The photo selection logic in PhotoList.tsx has been refactored to use a new 'setSelectedPhotos' action from the Zustand store, which improves the 'select all' functionality and prevents redundant updates. Minor UI color adjustments were also made. A review comment suggests extracting a helper function for the photo mapping logic in PhotoList.tsx to avoid code duplication and improve maintainability.

Comment on lines +181 to +186
setSelectedPhotos(
selectablePhotos.map(({ photoId, imageUrl }) => ({
id: photoId,
url: imageUrl ?? '',
})),
);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

이 사진 매핑 로직은 201번째 줄의 useEffect 훅에서도 동일하게 사용되고 있습니다. 코드 중복을 피하고 유지보수성을 높이기 위해 이 로직을 별도의 헬퍼 함수로 추출하는 것이 좋습니다. 예를 들어, 다음과 같은 함수를 PhotoList 컴포넌트 내에 선언하고 사용할 수 있습니다.

const mapToStorePhotos = (photos: typeof selectablePhotos) =>
  photos.map(({ photoId, imageUrl }) => ({
    id: photoId,
    url: imageUrl ?? '',
  }));

@dasosann dasosann merged commit 2dcae98 into main Mar 26, 2026
4 checks passed
@dasosann dasosann deleted the fix/selectmode-tooltip branch March 26, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant