Skip to content

feat: 로직 변경#201

Merged
dasosann merged 2 commits intomainfrom
fix/toggle-all
Mar 26, 2026
Merged

feat: 로직 변경#201
dasosann merged 2 commits intomainfrom
fix/toggle-all

Conversation

@dasosann
Copy link
Copy Markdown
Contributor

요약

구현 사항

  • [ ]
  • [ ]
  • [ ]
  • [ ]

📸 스크린샷

Need Review

  • ~ 부분 이렇게 구현했어요, 피드백 부탁해요!

Reference

📜 리뷰 규칙

Reviewer는 아래 P5 Rule을 참고하여 리뷰를 진행합니다.
P5 Rule을 통해 Reviewer는 Reviewee에게 리뷰의 의도를 보다 정확히 전달할 수 있습니다.

  • P1: 꼭 반영해주세요 (Comment)
  • P2: 적극적으로 고려해주세요 (Comment)
  • P3: 웬만하면 반영해 주세요 (Comment)
  • P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
  • P5: 그냥 사소한 의견입니다 (Approve)

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fe Ready Ready Preview, Comment Mar 26, 2026 7:48am

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 사진 목록 컴포넌트의 사용자 인터페이스와 내부 로직을 개선하여, 사용자가 사진을 선택하고 해제하는 경험을 더욱 직관적이고 효율적으로 만듭니다. 특히, 전체 선택/해제 버튼의 가시성과 동작 방식을 최적화하여 불필요한 상태 관리를 줄이고 코드의 가독성을 향상시켰습니다.

Highlights

  • 선택 로직 개선: 사진 목록에서 전체 선택 및 해제 버튼의 표시 로직이 개선되었습니다. 이제 isAllSelected 상태에 따라 '전체 선택' 또는 '전체 해제' 버튼이 조건부로 렌더링됩니다.
  • 불필요한 변수 제거: hasAnySelected 변수가 더 이상 사용되지 않아 제거되었습니다. 이는 코드의 간결성을 높입니다.
  • 버튼 텍스트 변경: 선택 해제 버튼의 텍스트가 '선택 해제'에서 '전체 해제'로 변경되어 의미가 더 명확해졌습니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dasosann dasosann merged commit 526cc67 into main Mar 26, 2026
4 checks passed
@dasosann dasosann deleted the fix/toggle-all branch March 26, 2026 07:49
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily refactors the photo selection UI in PhotoList.tsx. It includes a minor formatting adjustment for import statements. The hasAnySelected constant was removed, and the logic for the 'Select All' and 'Clear All' buttons was updated to dynamically toggle between them based on the isAllSelected state, providing a more intuitive user experience. There are no review comments to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant