Skip to content

Fix GitHubNetworkException wrap test logic for persistent network failures #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SayanthRock wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −13
Open

Fix GitHubNetworkException wrap test logic for persistent network failures #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...java/com/sayanthrock/rockreleasehub/core/network/auth/GitHubOAuthDeviceFlowGatewayTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,11 @@ class GitHubOAuthDeviceFlowGatewayTest {
caughtException?.message
)
assertTrue(caughtException?.cause is GitHubNetworkException)
assertEquals("Simulated network failure", caughtException?.cause?.cause?.message)
var rootCause = caughtException?.cause
while (rootCause?.cause != null) {
rootCause = rootCause.cause
}
assertEquals("Simulated network failure", rootCause?.message)
Comment thread
SayanthRock marked this conversation as resolved.
Comment thread
SayanthRock marked this conversation as resolved.

verify(exactly = 4) {
gateway invoke "postForm" withArguments listOf(any<String>(), any<Map<String, String>>())
Expand Down
12 changes: 0 additions & 12 deletions test-plan.md
View file
Open in desktop

This file was deleted.

Loading