Skip to content

🎨 Palette: [Add artwork alt text] #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SayanthRock merged 1 commit into from
Aug 2, 2026
+7 −3
Merged

🎨 Palette: [Add artwork alt text] #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,7 @@
## 2024-07-29 - [Search View Aesthetics]
**Learning:** `OutlinedTextField` provides a cleaner, more consistent look across search inputs compared to the default filled `TextField`, especially in minimal or dark themes where filled fields can feel heavy.
**Action:** Default to `OutlinedTextField` for primary search fields across the application to maintain a "neat and clean" standard look.

## 2024-08-01 - [Add Alt Text to Artwork Images]
**Learning:** `AsyncImage` components used for displaying track/album artwork often have `contentDescription = null` by default in lists. Adding dynamic alt text like `contentDescription = "Artwork for ${track.name}"` makes list traversal with screen readers significantly more informative.
**Action:** When adding images that provide visual context to list items (like album art), always provide a dynamic `contentDescription` based on the item's title rather than `null`.
4 changes: 2 additions & 2 deletions app/src/main/java/com/rockmusic/app/presentation/RockMusicRoot.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,7 @@ private fun TrackRow(track: LocalTrack, onPlay: (LocalTrack) -> Unit) {
) {
AsyncImage(
model = track.artworkUri,
contentDescription = null,
contentDescription = "Artwork for ${track.title}",
modifier = Modifier
.size(58.dp)
.clip(RoundedCornerShape(16.dp))
Expand Down Expand Up @@ -915,7 +915,7 @@ private fun MiniPlayer(
) {
AsyncImage(
model = player.artworkUri,
contentDescription = null,
contentDescription = "Artwork for ${player.title.orEmpty()}",

@coderabbitai coderabbitai Bot Aug 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Avoid an incomplete accessibility description.

When player.title is null or blank, player.title.orEmpty() produces Artwork for without an identifying title. Use a non-blank title or a meaningful fallback such as Artwork.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/com/rockmusic/app/presentation/RockMusicRoot.kt` at line
918, Update the contentDescription in RockMusicRoot to avoid constructing an
incomplete “Artwork for ” description when player.title is null or blank. Use
the non-blank player.title when available, otherwise fall back to the meaningful
description “Artwork”.

@codeant-ai codeant-ai Bot Aug 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: player.artworkUri is nullable, but this always supplies a non-null description, including when no artwork exists and AsyncImage renders no image. TalkBack can therefore announce “Artwork for …” for a nonexistent image; make the description conditional on a nonblank artwork URI, matching the fallback behavior used elsewhere. [logic error]

Severity Level: Major ⚠️ 
- ⚠️ Mini player announces nonexistent artwork.
- ⚠️ Screen-reader users receive misleading media context.
- ⚠️ Tracks without album art are affected.

Fix in Cursor Fix in VSCode Claude

(Use Cmd/Ctrl + Click for best experience)

Prompt for AI Agent 🤖 
This is a comment left during a code review.

**Path:** app/src/main/java/com/rockmusic/app/presentation/RockMusicRoot.kt
**Line:** 918:918
**Comment:**
	*Logic Error: `player.artworkUri` is nullable, but this always supplies a non-null description, including when no artwork exists and `AsyncImage` renders no image. TalkBack can therefore announce “Artwork for …” for a nonexistent image; make the description conditional on a nonblank artwork URI, matching the fallback behavior used elsewhere.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎

Comment on lines 916 to +918
modifier = Modifier
.size(50.dp)
.clip(RoundedCornerShape(14.dp))
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/rockmusic/app/presentation/integrations/SpotifyPlaylistPreviewCard.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ private fun SpotifyTrackRow(index: Int, track: SpotifyPlaylistTrackPreview) {
)
AsyncImage(
model = track.imageUrl,
contentDescription = null,
contentDescription = "Artwork for ${track.name}",
modifier = Modifier
Comment on lines 188 to 191
.size(44.dp)
.clip(RoundedCornerShape(10.dp)),
Expand Down
Loading