Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ class MediaStoreLocalMusicRepository @Inject constructor(
if (!hasPersistedReadAccess) {
Log.w(
TAG,
"Persistent read access was not granted for $uri; the file may need to be selected again after restart.",
"Persistent read access was not granted for the file; it may need to be selected again after restart.",
)
}

Expand Down Expand Up @@ -251,7 +251,7 @@ class MediaStoreLocalMusicRepository @Inject constructor(
} catch (error: CancellationException) {
throw error
} catch (error: Throwable) {
Log.w(TAG, "Skipping unreadable audio URI: $uri", error)
Log.w(TAG, "Skipping unreadable audio URI", error)
Comment thread
SayanthRock marked this conversation as resolved.
null
}
}
Expand Down
6 changes: 3 additions & 3 deletions pr_description.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
🎯 What: Added tests for `EncryptedSpotifyPkceRequestStore` to address the untested timing edge case in `consume` and ensure proper behavior when the request is expired, valid, or has a mismatched state.
πŸ“Š Coverage: Added coverage for `consume` (valid request, expired request, incorrect state) and `clearExpired` (valid request, expired request).
✨ Result: Improved reliability of the Spotify PKCE request handling by explicitly validating the `System.currentTimeMillis()` based expiration logic.
🎯 **What:** Removed sensitive URI information from error and warning logs in `LocalMusicRepository.kt`.
⚠️ **Risk:** If an attacker gains access to the application logs (e.g., through logcat on a compromised device or via another vulnerability), they could potentially obtain sensitive file paths or document URIs that point to user data.
πŸ›‘οΈ **Solution:** Replaced the `$uri` string interpolation in `Log.w` statements with generic placeholders ("the file" and "audio URI") to prevent the exact path from being leaked into the system logs while retaining the diagnostic value of the warning.
Loading