Skip to content

🧹 [Code Health] Use Android's built-in file size formatter in FolderManagerScreen #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SayanthRock wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −12
Open

🧹 [Code Health] Use Android's built-in file size formatter in FolderManagerScreen #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,6 @@
## 2024-08-02 - Debouncing and offloading state derivation in Jetpack Compose
**Learning:** In Jetpack Compose, computing expensive operations (like filtering large lists based on user input) directly within a synchronous `remember` block blocks the main UI thread. When this happens on every keystroke in a `TextField`, it causes significant UI stutter and input lag.
**Action:** To prevent UI stutter during expensive state derivation, debounce the input using `LaunchedEffect` with `delay` and offload the computation to a background thread using `withContext(Dispatchers.Default)`. This keeps the main thread responsive for typing and animations.
## 2024-08-04 - Code Health Improvement: Use Android's built-in file size formatter
**Learning:** For file size formatting in Android, use `android.text.format.Formatter.formatShortFileSize` or `android.text.format.Formatter.formatFileSize` instead of writing a custom byte conversion function. It's safer, more idiomatic, correctly respects the locale, and reduces boilerplate code.
**Action:** When working with file sizes in a Compose/Android context, default to using the Android framework's built-in `Formatter` utilities instead of custom implementations.
15 changes: 3 additions & 12 deletions app/src/main/java/com/rockmusic/app/presentation/FolderManagerScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import android.net.Uri
import android.os.Build
import android.provider.Settings
import androidx.activity.compose.BackHandler
import android.text.format.Formatter
import androidx.activity.compose.rememberLauncherForActivityResult
import androidx.activity.result.contract.ActivityResultContracts
import androidx.compose.foundation.layout.Arrangement
Expand Down Expand Up @@ -317,6 +318,7 @@ private fun FolderRow(
enabled: Boolean,
onIncludedChange: (Boolean) -> Unit,
) {
val context = LocalContext.current
Surface(
shape = RoundedCornerShape(20.dp),
color = if (included) {
Expand Down Expand Up @@ -347,7 +349,7 @@ private fun FolderRow(
overflow = TextOverflow.Ellipsis,
)
Text(
"${folder.songCount} song${if (folder.songCount == 1) "" else "s"} · ${formatBytes(folder.totalBytes)}",
"${folder.songCount} song${if (folder.songCount == 1) "" else "s"} · ${Formatter.formatShortFileSize(context, folder.totalBytes)}",
style = MaterialTheme.typography.bodySmall,
color = MaterialTheme.colorScheme.onSurfaceVariant,
)
Expand All @@ -362,14 +364,3 @@ private fun FolderRow(
}
}

private fun formatBytes(bytes: Long): String {
if (bytes < 1_024L) return "$bytes B"
val units = arrayOf("KB", "MB", "GB", "TB")
var value = bytes.toDouble()
var unitIndex = -1
while (value >= 1_024.0 && unitIndex < units.lastIndex) {
value /= 1_024.0
unitIndex += 1
}
return String.format(Locale.getDefault(), "%.1f %s", value, units[unitIndex])
}
Loading