Skip to content

🎨 Palette: Add search IME action to keyboard #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SayanthRock wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

🎨 Palette: Add search IME action to keyboard #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,7 @@
## 2024-08-01 - [Add Alt Text to Artwork Images]
**Learning:** `AsyncImage` components used for displaying track/album artwork often have `contentDescription = null` by default in lists. Adding dynamic alt text like `contentDescription = "Artwork for ${track.name}"` makes list traversal with screen readers significantly more informative.
**Action:** When adding images that provide visual context to list items (like album art), always provide a dynamic `contentDescription` based on the item's title rather than `null`.

## 2024-08-07 - [Added Keyboard IME Actions to TextFields]
**Learning:** By default, single-line text fields on Android show a generic "Done" or "Enter" action on the soft keyboard. Setting `keyboardOptions = KeyboardOptions(imeAction = ImeAction.Search)` for search inputs provides a clearer visual cue (a search icon) and better aligns with user expectations for search interactions.
**Action:** Always provide appropriate `keyboardOptions` (like `ImeAction.Search`, `ImeAction.Done`, `ImeAction.Go`) for `TextField` and `OutlinedTextField` components based on their context to improve the mobile keyboard experience.
4 changes: 4 additions & 0 deletions app/src/main/java/com/rockmusic/app/presentation/RockMusicExperience.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import androidx.compose.foundation.lazy.LazyRow
import androidx.compose.foundation.lazy.items
import androidx.compose.foundation.shape.CircleShape
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.foundation.text.KeyboardOptions
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.rounded.Add
import androidx.compose.material.icons.rounded.Close
Expand Down Expand Up @@ -83,6 +84,7 @@ import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.semantics.contentDescription
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.text.input.ImeAction
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.unit.Dp
import androidx.compose.ui.unit.dp
Expand Down Expand Up @@ -360,6 +362,7 @@ private fun ExperienceHome(
},
label = { Text("Search songs or YouTube Music") },
leadingIcon = { Icon(Icons.Rounded.Search, contentDescription = null) },
keyboardOptions = KeyboardOptions(imeAction = ImeAction.Search),

@codeant-ai codeant-ai Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: The field now advertises a Search IME action, but it does not provide keyboardActions or an onKeyboardAction handler. Pressing the keyboard Search key therefore will not invoke the existing onYouTubeSearch/onYouTubeLink callbacks used by the trailing action button; it will only perform the default IME behavior, so users cannot submit a YouTube search or link from the keyboard. [api mismatch]

Severity Level: Major ⚠️ 
- ⚠️ Home search IME key does not execute YouTube searches.
- ⚠️ Pasted YouTube links require a separate button tap.
- ⚠️ Keyboard-focused users lose the advertised Search action.

Fix in Cursor Fix in VSCode Claude

(Use Cmd/Ctrl + Click for best experience)

Prompt for AI Agent 🤖 
This is a comment left during a code review.

**Path:** app/src/main/java/com/rockmusic/app/presentation/RockMusicExperience.kt
**Line:** 365:365
**Comment:**
	*Api Mismatch: The field now advertises a Search IME action, but it does not provide `keyboardActions` or an `onKeyboardAction` handler. Pressing the keyboard Search key therefore will not invoke the existing `onYouTubeSearch`/`onYouTubeLink` callbacks used by the trailing action button; it will only perform the default IME behavior, so users cannot submit a YouTube search or link from the keyboard.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎

trailingIcon = {
Row(verticalAlignment = Alignment.CenterVertically) {
if (query.isNotBlank()) {
Expand Down Expand Up @@ -651,6 +654,7 @@ private fun ExperienceLibrary(
},
placeholder = { Text("Songs, artists, or albums") },
singleLine = true,
keyboardOptions = KeyboardOptions(imeAction = ImeAction.Search),
shape = RoundedCornerShape(22.dp),
modifier = Modifier.fillMaxWidth(),
)
Expand Down
3 changes: 3 additions & 0 deletions app/src/main/java/com/rockmusic/app/presentation/RockMusicRoot.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import androidx.compose.foundation.lazy.LazyRow
import androidx.compose.foundation.lazy.items
import androidx.compose.foundation.shape.CircleShape
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.foundation.text.KeyboardOptions
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.rounded.Add
import androidx.compose.material.icons.rounded.BlurOn
Expand Down Expand Up @@ -88,6 +89,7 @@ import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.vector.ImageVector
import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.text.input.ImeAction
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.unit.dp
import androidx.core.content.ContextCompat
Expand Down Expand Up @@ -519,6 +521,7 @@ private fun SearchScreen(tracks: List<LocalTrack>, onPlay: (LocalTrack) -> Unit)
},
placeholder = { Text("Songs, artists, albums, podcasts") },
singleLine = true,
keyboardOptions = KeyboardOptions(imeAction = ImeAction.Search),
shape = RoundedCornerShape(22.dp),
modifier = Modifier.fillMaxWidth(),
)
Expand Down
Loading