feat: add command timeouts#32
Merged
salazarsebas merged 2 commits intoScaffoldRust:mainfrom Aug 8, 2025
Merged
Conversation
Add timeout enforcement to commandExecutor utility to prevent long-running commands from hanging the backend. - Implement executeCommand function with 30-second default timeout - Add CommandTimeoutError with clear error messaging - Use setTimeout and child.kill() for timeout enforcement - Capture stdout/stderr before timeout occurs - Ensure proper cleanup of child processes - Add executeCommandWithTimeout convenience wrapper Tested timeout behavior with sleep commands to verify functionality works correctly.
- Format commandExecutor.ts to match project code style - Ensure consistent formatting across the codebase - All files now pass Prettier checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Add timeout enforcement to the
commandExecutorutility to prevent long-running or infinite commands from hanging the backend. This is critical for security and reliability, as Rust compilation and testing can be resource-intensive. By setting a 30-second timeout, we ensure the backend remains responsive and aligns with the project's security requirements.🚀 Changes Made
executeCommandfunction with 30-second default timeoutCommandTimeoutErrorwith clear error messagingsetTimeoutandchild.kill()for timeout enforcementexecuteCommandWithTimeoutconvenience wrapper🗂️ Files Added
apps/backend/src/utils/
└── commandExecutor.ts
🧪 Testing
Command timeout functionality is working correctly!🔒 Security Benefits
💡 Usage Example
🔗 Closes
Closes #30
📋 Checklist