Skip to content

fix(gomock_generator): Fix go.mod #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(gomock_generator): Fix go.mod #1071

wants to merge 1 commit into from

Conversation

brandon-welsch
Copy link
Member

Fix #1070

EtienneM
EtienneM requested changes Feb 10, 2025
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is odd. This is how we specify the Go version in all our go.mod files now.

I'm not sure I understand which component returns the error in the related issue. Could you explain?

@brandon-welsch
Copy link
Member Author

go build and go install doesn't work to build this package as said in the README of the package. The error seems pretty clear. I removed the patch version and it now work properly so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneM EtienneM EtienneM requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gomock_generator] Issue to parse go version in go.mod
2 participants
@brandon-welsch @EtienneM