fix PR template sectioning#8
Merged
Merged
Conversation
Signed-off-by: Lukas Kollmer <hey@lukaskollmer.de>
Signed-off-by: Lukas Kollmer <hey@lukaskollmer.de>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request template updates the heading levels for “Current situation & Problem,” “Release Notes,” “Documentation,” and “Testing” from 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
@PSchmiedmayer this obviously is a very subjective thing, so feel free to reject if you prefer the current setup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix PR template sectioning
♻️ Current situation & Problem
this has actually been bugging me for ages: the last section in the PR template (code of conduct) is using a higher heading level than the other sections (3 vs 2); causing it to appear as if it were a sub-section of the previous section (Testing).
see eg this PR (which was created using the old template).
the proposed fix here is to bring the PR template in line with what we get from the issue templates:
⚙️ Release Notes
📚 Documentation
n/a
✅ Testing
n/a
Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: