Wearable integrations#193
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| const code = | ||
| typeof req.query.code === "string" ? req.query.code : undefined; | ||
| const state = | ||
| typeof req.query.state === "string" ? req.query.state : undefined; | ||
| const providerError = | ||
| typeof req.query.error === "string" ? req.query.error : undefined; |
There was a problem hiding this comment.
We might want to handle this with zod.
PSchmiedmayer
left a comment
There was a problem hiding this comment.
@pauljohanneskraft Thanks for kickstarting this here. It's essential that the data storage is in the storage bucket + statistics in the Firestone.
Storage needs to be in the storage bucket, in FHIR, and compressed files as done by the iOS app and future android app. Metadata needs to be fully aligned + a clear way that we have same LOINC code as iOS app but at the same time some device-specific codes as we have them for the HealthKit code mapping on iOS. To sync with @PaulGoldschmidt and @lukaskollmer here 👍
Statistics and metrics need to be aligned with the ongoing iOS development; this needs to be the same format and clearly defined so e.g. the iOS app dashboard and status of study would pick up any elements coming from these devices and not just HealthKit + the future dashboard will be able to show all of this. To sync with @lukaskollmer in detail.
Wearable integrations
♻️ Current situation & Problem
We would like to integrate a couple of wearable services to also allow us to read data directly from each provider rather than going through Apple HealthKit / Google HealthConnect, as some data may not be imported into those services and/or not contain all the detail we want to capture.
⚙️ Release Notes
📚 Documentation
Please ensure that you properly document any additions in conformance with the project's documentation guidelines.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using inline documentation.
✅ Testing
Please ensure that the PR meets the testing requirements set by Codecov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.
Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.